Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Endianness and Parameter Endianness #429

Closed
jtlobdell opened this issue Apr 27, 2017 · 4 comments
Closed

Command Endianness and Parameter Endianness #429

jtlobdell opened this issue Apr 27, 2017 · 4 comments
Assignees
Labels
Milestone

Comments

@jtlobdell
Copy link
Contributor

@jtlobdell jtlobdell commented Apr 27, 2017

Does COSMOS support parameter-specific endainness? Example: a command is big endian and has 4 parameters of which the last two are little endian.

Looking at packet_item_parser.rb (specifically get_usage and get_endianness) it seems like this is supported. I did a basic test of modifying the demo cmd config like get_usage shows (just adding LITTLE_ENDIAN after the parameter description), sending the command and viewing the raw command packet but I see no indication that the endianness is actually different.

If it isn't a feature then I'm going to take a stab at implementing it.

If it is already a feature then:
--It is undocumented, at least on the "Command and Telemetry Configuration" page
--Whether it is working is not obvious
--I didn't see any tests for this (to be fair I didn't dig for more than a minute)

@ryanatball
Copy link
Member

@ryanatball ryanatball commented Apr 27, 2017

It is supported.
It is undocumented (will leave this ticket open until that gets fixed).
It is tested (see packet_item_parser_spec.rb lines 136 and 270)

If it is not working for some specific case please let me know.

@donaldatball
Copy link
Collaborator

@donaldatball donaldatball commented Jun 7, 2017

@ryanatball @jasonatball - I added documentation of the endian parameter to all the item/parameter keywords in the cmd/tlm section of the website. I think that is all that needed to happen for this ticket.

Someone want to review the changes?

@jasonatball
Copy link
Collaborator

@jasonatball jasonatball commented Jun 7, 2017

Looks good. 👍

@donaldatball
Copy link
Collaborator

@donaldatball donaldatball commented Jun 7, 2017

Closed with website updates only (2971e24)

@ryanatball ryanatball modified the milestone: v4.0.0 Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.