Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packet Viewer should identify Derived items in the GUI #441

Closed
jmthomas opened this issue May 8, 2017 · 5 comments
Closed

Packet Viewer should identify Derived items in the GUI #441

jmthomas opened this issue May 8, 2017 · 5 comments
Assignees
Labels
Milestone

Comments

@jmthomas
Copy link
Member

@jmthomas jmthomas commented May 8, 2017

We already have an option to display derived items last but currently it's impossible to tell which items are derived without clicking Details on each one. Perhaps included a (D) after the item name to indicate derived. This matches the colorblind convention of adding (G) after a green item.

@jmthomas jmthomas added the feature label May 8, 2017
@jmthomas jmthomas self-assigned this May 9, 2017
@jmthomas
Copy link
Member Author

@jmthomas jmthomas commented May 9, 2017

image

@ryanatball, @donaldatball any thoughts?

@ryanatball
Copy link
Member

@ryanatball ryanatball commented May 9, 2017

How about just adding a * ?

@donaldatball
Copy link
Collaborator

@donaldatball donaldatball commented May 9, 2017

I'm ok either way on that front. My question is, are the RECEIVED_* built-ins considered derived or should they be distinguished somehow?

@jmthomas
Copy link
Member Author

@jmthomas jmthomas commented May 9, 2017

They're not explicitly derived in the cmd/tlm definitions but they are derived items so I'm going to mark them as such. I think the * looks better.

@jasonatball
Copy link
Collaborator

@jasonatball jasonatball commented May 9, 2017

Closed by #444

@jasonatball jasonatball closed this May 9, 2017
@ryanatball ryanatball modified the milestone: v3.9.2 May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.