Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay doesn't shut down properly if closed while playing #456

Closed
donaldatball opened this issue May 19, 2017 · 1 comment
Closed

Replay doesn't shut down properly if closed while playing #456

donaldatball opened this issue May 19, 2017 · 1 comment
Assignees
Labels
bug
Milestone

Comments

@donaldatball
Copy link
Collaborator

@donaldatball donaldatball commented May 19, 2017

If the replay tool is closed while playing, the process doesn't completely go away. If the user tries to start CTS or Replay again, the CTS port is still in use.

I haven't dug into it very deep yet, but I suspect the @playback_thread isn't being killed when the application is closed.

@donaldatball donaldatball self-assigned this May 19, 2017
donaldatball added a commit that referenced this issue May 19, 2017
…ool is closed while playback is active.
donaldatball added a commit that referenced this issue May 19, 2017
re #456 Update replay so it'll shut down the playback thread if the t…
@donaldatball
Copy link
Collaborator Author

@donaldatball donaldatball commented May 19, 2017

Closed with c39405d

@ryanatball ryanatball added the bug label May 24, 2017
@ryanatball ryanatball modified the milestone: v4.0.0 Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.