Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limits Monitor doesn't detect newly connected targets #479

Closed
jasonatball opened this issue Jun 12, 2017 · 2 comments
Closed

Limits Monitor doesn't detect newly connected targets #479

jasonatball opened this issue Jun 12, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@jasonatball
Copy link
Collaborator

@jasonatball jasonatball commented Jun 12, 2017

If you start the demo and then launch the Simulated Targets and connect EXAMPLE_INT you won't see the VALUE item as Red. File->Reset and you'll see it.

Also if you have previously ignored a Packet and then start receiving telemetry you won't see any Red/Yellow items until you remove the ignored packet AND Reset. I don't think this should be the default behavior. You want to ignore the fact that it is stale, not all the limits items in the packet.

@ryanatball
Copy link
Member

@ryanatball ryanatball commented Jun 22, 2017

Need to differentiate ignoring stale from real limits events

@ryanatball ryanatball added feature and removed possible bug labels Jun 22, 2017
donaldatball added a commit that referenced this issue Jul 5, 2017
… packets and ignoring out-of-limits items. Also rework the GUI a little bit so full item names are displayed, and provide the option to ignore items or packets for out-of-limits items.
donaldatball added a commit that referenced this issue Jul 6, 2017
…lation of labelvaluelimitsbar widget, and remove deprecated comment.
donaldatball added a commit that referenced this issue Jul 6, 2017
donaldatball added a commit that referenced this issue Jul 7, 2017
re #479 Update Limits Monitor to differentiate between ignoring stale…
@donaldatball
Copy link
Collaborator

@donaldatball donaldatball commented Jul 7, 2017

Closed with 210ca71

@ryanatball ryanatball modified the milestone: v4.0.0 Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.