Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call read_interface if data is cached in protocols for another packet #506

Closed
ghost opened this issue Jul 6, 2017 · 0 comments · Fixed by #508
Closed

Don't call read_interface if data is cached in protocols for another packet #506

ghost opened this issue Jul 6, 2017 · 0 comments · Fixed by #508
Labels
Milestone

Comments

@ghost
Copy link

ghost commented Jul 6, 2017

Interface.rb needs to give the protocols a chance to output another packet, before calling read_interface again. Otherwise they can be blocked on a socket, when the protocols already have enough data to output another packet.

@ghost ghost self-assigned this Jul 6, 2017
@ghost ghost added the bug label Jul 6, 2017
@ghost ghost closed this as completed in #508 Jul 7, 2017
@ghost ghost modified the milestone: v4.0.0 Aug 4, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants