New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestRunner strips all comments when running #533

Closed
jasonatball opened this Issue Aug 10, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@jasonatball
Collaborator

jasonatball commented Aug 10, 2017

This is probably due to something that was implemented for ConfigEditor in the base classes

@jasonatball jasonatball added the bug label Aug 10, 2017

@jasonatball jasonatball self-assigned this Aug 10, 2017

@jasonatball

This comment has been minimized.

Show comment
Hide comment
@jasonatball

jasonatball Aug 10, 2017

Collaborator

Unable to reproduce. I think I had an old instrumented script with some issues.

Collaborator

jasonatball commented Aug 10, 2017

Unable to reproduce. I think I had an old instrumented script with some issues.

@jasonatball jasonatball reopened this Aug 21, 2017

@jasonatball

This comment has been minimized.

Show comment
Hide comment
@jasonatball

jasonatball Aug 21, 2017

Collaborator

Another user has also reported this happening.

Collaborator

jasonatball commented Aug 21, 2017

Another user has also reported this happening.

@jasonatball

This comment has been minimized.

Show comment
Hide comment
@jasonatball

jasonatball Aug 21, 2017

Collaborator

@ryanmelt, @donaldatball
I determined this was happening on an initial load of Test Runner without any instrumented scripts. When I initially run there are no comments. If you shut down Test Runner and run again you get comments back. Please confirm.

I think I traced it down to this commit 7aa187d. When I reverted it I got comments back on the first run. Can you guys confirm?

Collaborator

jasonatball commented Aug 21, 2017

@ryanmelt, @donaldatball
I determined this was happening on an initial load of Test Runner without any instrumented scripts. When I initially run there are no comments. If you shut down Test Runner and run again you get comments back. Please confirm.

I think I traced it down to this commit 7aa187d. When I reverted it I got comments back on the first run. Can you guys confirm?

ryanatball added a commit that referenced this issue Aug 23, 2017

Merge pull request #549 from BallAerospace/fix_stripped_comments
closes #533. Fix stripped comments on first run

@ryanatball ryanatball modified the milestone: v4.0.1 Aug 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment