Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upGracefully handle large array items #650
Comments
jasonatball
added
the
feature
label
Nov 14, 2017
jasonatball
self-assigned this
Dec 11, 2017
jasonatball
closed this
in
#685
Dec 18, 2017
ryanatball
added this to the v4.2.2 milestone
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jasonatball commentedNov 14, 2017
A user created a packet which contained the following item:
APPEND_ARRAY_ITEM DATA 16 UINT 16777216 "Buffer of two-byte unsigned integer pixel values"
COSMOS happily parsed this definition but then Packet Viewer chokes when trying to display it and Script Runner freezes when trying to check the data in a script. I think this is just an issue with ARRAY_ITEM but we should investigate boundary conditions with STRING and BLOCK as well.
We either need to disallow certain size items or pop up a warning saying your performance will suffer. The cut off could be difficult to determine considering different machine specs.