Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle large array items #650

Closed
jasonatball opened this issue Nov 14, 2017 · 0 comments
Closed

Gracefully handle large array items #650

jasonatball opened this issue Nov 14, 2017 · 0 comments
Assignees
Labels
Milestone

Comments

@jasonatball
Copy link
Collaborator

@jasonatball jasonatball commented Nov 14, 2017

A user created a packet which contained the following item:
APPEND_ARRAY_ITEM DATA 16 UINT 16777216 "Buffer of two-byte unsigned integer pixel values"

COSMOS happily parsed this definition but then Packet Viewer chokes when trying to display it and Script Runner freezes when trying to check the data in a script. I think this is just an issue with ARRAY_ITEM but we should investigate boundary conditions with STRING and BLOCK as well.

We either need to disallow certain size items or pop up a warning saying your performance will suffer. The cut off could be difficult to determine considering different machine specs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.