New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XTCE String types should not have ByteOrderList #701

Closed
jasonatball opened this Issue Jan 12, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@jasonatball
Collaborator

jasonatball commented Jan 12, 2018

Strings are always single byte values so don't do anything with endianness.

@severn

This comment has been minimized.

severn commented Jan 16, 2018

Some kinds of char encodings are multi-byte. I wouldn't necessarily say all strings then can't have a byte order. However XTCE 1.1 is a little broken or at least poor in this area, there's an attempt to clean it up in XTCE 1.2 -- but its not out yet.

@ryanatball

This comment has been minimized.

Member

ryanatball commented Jan 16, 2018

COSMOS doesn't currently support character encodings, so for now, endianness of strings has no meaning or effect within COSMOS.

@severn

This comment has been minimized.

severn commented Jan 17, 2018

I'm trying to decide how this should be handled. I suppose if it appears, you could either totally stop or issue a warning. Should the element be pre-filtered it out so the file can be accepted?
Right now I already have a filter oriented program for cosmos xtce. It takes out elements that are not supported or that gum up the parser because it's event based & sometimes catches elements out of context. May not be current.

@jasonatball

This comment has been minimized.

Collaborator

jasonatball commented Jan 17, 2018

If you have a pull request we'll be happy to take a look at it once you sign the Contributor License Agreement.

@ryanatball ryanatball added this to the v4.2.2 milestone Apr 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment