Refactor binary_accessor #72

Closed
jmthomas opened this Issue Feb 20, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@jmthomas
Member

jmthomas commented Feb 20, 2015

BinaryAccessor has been on my todo for a while. It always shows up with tons of duplication and complexity.

@ryanatball

This comment has been minimized.

Show comment
Hide comment
@ryanatball

ryanatball Feb 20, 2015

Member

You're just going to rewrite the whole thing in C right? ;)

Member

ryanatball commented Feb 20, 2015

You're just going to rewrite the whole thing in C right? ;)

@jmthomas

This comment has been minimized.

Show comment
Hide comment
@jmthomas

jmthomas Feb 20, 2015

Member

Were you still planning on making this a separate gem?

Member

jmthomas commented Feb 20, 2015

Were you still planning on making this a separate gem?

@ryanatball

This comment has been minimized.

Show comment
Hide comment
@ryanatball

ryanatball Feb 20, 2015

Member

I licensed binary_accessor/structure and json_drb differently with the end goal of making them seperate LGPL gems.

Member

ryanatball commented Feb 20, 2015

I licensed binary_accessor/structure and json_drb differently with the end goal of making them seperate LGPL gems.

@jmthomas

This comment has been minimized.

Show comment
Hide comment
@jmthomas

jmthomas Feb 20, 2015

Member

Might be a chance to brush up on my C extension skills. I'll take a crack at it.

Member

jmthomas commented Feb 20, 2015

Might be a chance to brush up on my C extension skills. I'll take a crack at it.

@jmthomas

This comment has been minimized.

Show comment
Hide comment
@jmthomas

jmthomas Feb 23, 2015

Member

I don't know that I should prematurely optimize this into a C extension if you want to make it more widely available. Making it a C extension prevents Rubinious and JRuby users from using it. Although we've already been forced to a partial C extension due to performance.

Member

jmthomas commented Feb 23, 2015

I don't know that I should prematurely optimize this into a C extension if you want to make it more widely available. Making it a C extension prevents Rubinious and JRuby users from using it. Although we've already been forced to a partial C extension due to performance.

jmthomas pushed a commit that referenced this issue Apr 3, 2015

jmthomas pushed a commit that referenced this issue Apr 3, 2015

jmthomas pushed a commit that referenced this issue Apr 3, 2015

jmthomas pushed a commit that referenced this issue Apr 6, 2015

jmthomas pushed a commit that referenced this issue Apr 8, 2015

@jmthomas jmthomas self-assigned this Apr 10, 2015

@jmthomas jmthomas closed this Apr 17, 2015

jmthomas pushed a commit that referenced this issue Apr 20, 2015

jmthomas pushed a commit that referenced this issue Apr 20, 2015

@ryanatball ryanatball modified the milestone: v3.4.0 Apr 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment