New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo INST commanding screen broken #752

Closed
jasonatball opened this Issue Apr 3, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@jasonatball
Collaborator

jasonatball commented Apr 3, 2018

This commit bdfc4fd broke the demo commanding screen because the button code is now being executed in a new thread and can't call the QT GUI.

@jasonatball

This comment has been minimized.

Collaborator

jasonatball commented Apr 3, 2018

@ryanatball This was implemented due to ticket #673 but I think I've effectively obfuscated the basic use case because now you have to wrap everything in Qt.execute_in_main_thread to do anything. I'd like to basically revert this change and create a new widget called backgroundbutton_widget which spawns the new thread. This way the default use case of simply reading another GUI element "just works" but you can use backgroundbutton_widget to do all kinds of fancy stuff without blocking the GUI. Thoughts?

@ryanatball

This comment has been minimized.

Member

ryanatball commented Apr 3, 2018

That sounds fair. Unfortunately we are bound by the GUI on this, having the buttons execute in a thread is a better solution otherwise. I'm guessing a lot more files would need to change to add the execute_in_main_thread calls into the widgets such that the button evaled code wouldn't need to care?

@jasonatball

This comment has been minimized.

Collaborator

jasonatball commented Apr 3, 2018

Right. Obviously the demo has broken. I'm not sure how many people use buttons on screens but having to wrap everything in execute_in_main_thread makes that screen definition file much more unwieldy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment