Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Items with STATE cannot define FORMAT_STRING #807

Closed
ryanatball opened this issue Jun 18, 2018 · 1 comment
Closed

Revert Items with STATE cannot define FORMAT_STRING #807

ryanatball opened this issue Jun 18, 2018 · 1 comment
Labels
Milestone

Comments

@ryanatball
Copy link
Member

@ryanatball ryanatball commented Jun 18, 2018

This change captured the common case that if a state is applied format strings aren't. However, for values that fall outside of the realm of defined states, format strings can still be applied. Convert this configuration error into a warning.

@ryanatball
Copy link
Member Author

@ryanatball ryanatball commented Jul 17, 2018

Also make the same change for UNITS

ryanatball added a commit that referenced this issue Jul 17, 2018
closes #807. Revert no UNITS if STATES
@ryanatball ryanatball added this to the v4.3.0 milestone Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant