Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UNKNOWN target identifies all buffers before other targets have a chance #81

Closed
jmthomas opened this issue Mar 2, 2015 · 1 comment
Closed
Assignees
Labels
bug
Milestone

Comments

@jmthomas
Copy link
Member

@jmthomas jmthomas commented Mar 2, 2015

The UNKNOWN target is created with an UNKNOWN command and an UNKNOWN telemetry packet that have no parameters/items. When you call commands.identify or telemetry.identify, if a packet is defined without any ID_PARAMETERS or ID_ITEMS then it is immediately identified with whatever buffer you pass it. Thus the first packet which has no ID items will identify everything. Since the target_names routine sorts the targets, any targets alphabetically past “UNKNOWN” won’t ever get their packets identified.

@ryanatball
Copy link
Member

@ryanatball ryanatball commented Mar 13, 2015

Fixing by having target_names() not include UNKNOWN. We had to work around it in many places so this actually makes the code a bit cleaner.

ryanatball added a commit that referenced this issue Mar 16, 2015
…-not-include-UNKNOWN

closes #81 Make target_names not include UNKNOWN
@ryanatball ryanatball added this to the v3.3.1 milestone Mar 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.