UNKNOWN target identifies all buffers before other targets have a chance #81

Closed
jmthomas opened this Issue Mar 2, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@jmthomas
Member

jmthomas commented Mar 2, 2015

The UNKNOWN target is created with an UNKNOWN command and an UNKNOWN telemetry packet that have no parameters/items. When you call commands.identify or telemetry.identify, if a packet is defined without any ID_PARAMETERS or ID_ITEMS then it is immediately identified with whatever buffer you pass it. Thus the first packet which has no ID items will identify everything. Since the target_names routine sorts the targets, any targets alphabetically past “UNKNOWN” won’t ever get their packets identified.

@ryanatball

This comment has been minimized.

Show comment
Hide comment
@ryanatball

ryanatball Mar 13, 2015

Member

Fixing by having target_names() not include UNKNOWN. We had to work around it in many places so this actually makes the code a bit cleaner.

Member

ryanatball commented Mar 13, 2015

Fixing by having target_names() not include UNKNOWN. We had to work around it in many places so this actually makes the code a bit cleaner.

ryanatball added a commit that referenced this issue Mar 16, 2015

Merge pull request #84 from BallAerospace/bugfix/81-make-target-names…
…-not-include-UNKNOWN


closes #81 Make target_names not include UNKNOWN

@ryanatball ryanatball added this to the v3.3.1 milestone Mar 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment