Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when accessing packets during initialization #964

Closed
ryanatball opened this issue Mar 22, 2019 · 0 comments
Closed

Improve error message when accessing packets during initialization #964

ryanatball opened this issue Mar 22, 2019 · 0 comments
Labels
Milestone

Comments

@ryanatball
Copy link
Member

@ryanatball ryanatball commented Mar 22, 2019

Per Robin:

I ran into something today that I thought y’all might be interested in. I was working on some derived code, and the C&T server kept crashing during the config load with a less-than-enlightening “no _dump_data is defined for class Thread::Mutex” error. Turns out this was caused by inadvertently reading a packet value during Conversion#initialize, which renders the packet un-dumpable since it creates a Mutex. While it’s probably best practice to avoid doing this (e.g. trying to read an undefined packet), it still seems like unexpected behavior that could cause headaches for others too.

@ryanatball ryanatball closed this in 31ca38b Apr 2, 2019
ryanatball added a commit that referenced this issue Apr 2, 2019
closes #964 Improve error message for packet mutex breaking marshal dump
@ryanatball ryanatball added this to the v4.4.0 milestone Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant