Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScriptRunner breakpoints don't get set on the correct line #978

Closed
donaldatball opened this issue Apr 15, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@donaldatball
Copy link
Collaborator

commented Apr 15, 2019

Describe the bug
ScriptRunner debugger mode breakpoints don't show up on the correct line.

To Reproduce
Steps to reproduce the behavior:

  1. Open ScriptRunner (I used the demo config)
  2. Create a few lines of script. I did this:
    puts "line 1"
    puts "line 2"
    puts "line 3"
    ...
    puts "line 8"
  3. Enable the debugger (Script -> Toggle Debug)
  4. Put the cursor on various lines, right click, add breakpoint. Breakpoint occasionally shows up on the correct line, but much more commonly shows up one or more lines below the desired line.

Expected behavior
Expect breakpoint to be created on the line where the cursor is blinking.

Environment (please complete the following information):

  • OS: Windows 10
  • COSMOS Version: master ff63725

@donaldatball donaldatball added the bug label Apr 15, 2019

@donaldatball donaldatball self-assigned this Apr 15, 2019

donaldatball added a commit that referenced this issue Apr 15, 2019

donaldatball added a commit that referenced this issue Apr 16, 2019

Merge pull request #979 from BallAerospace/scriptrunner_fix_breakpoin…
…t_lines

re #978 Use block bounding geometry to ensure ScriptRunner breakpoint…
@donaldatball

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 16, 2019

Closing with 16d5a8c

@ryanatball ryanatball added this to the v4.4.0 milestone Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.