Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support large DART queries in TlmExtractor and TlmGrapher #1078

Merged
1 commit merged into from Nov 18, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 4, 2019

closes #821

@ghost ghost self-requested a review November 4, 2019 23:56
# Implement constants common to DART (Data Archival Retrieval and Trending).
module DartConstants
# @return [Integer] maximum number of results returned from a decommutation query
MAX_DECOM_RESULTS = 10000
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seemed to be sprinkled everywhere so I made it a constant. I initially put it in Common but that didn't work due to it bringing in the Rails models.

@codecov-io
Copy link

codecov-io commented Nov 5, 2019

Codecov Report

Merging #1078 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1078   +/-   ##
=======================================
  Coverage   84.15%   84.15%           
=======================================
  Files         165      165           
  Lines       15746    15746           
=======================================
  Hits        13251    13251           
  Misses       2495     2495

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 800ad20...2c8682c. Read the comment docs.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ghost ghost merged commit ed39148 into master Nov 18, 2019
@ghost ghost deleted the larger_dart_samples branch November 18, 2019 18:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support DART queries larger than 10000 samples in TlmExtractor / TlmGrapher
2 participants