New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Search Bar to CmdSender #771

Merged
merged 2 commits into from Apr 17, 2018

Conversation

Projects
None yet
3 participants
@aaronatball
Contributor

aaronatball commented Apr 13, 2018

The purpose of this pull request is to add a search feature to CmdSender similar to that of PacketViewer.

The differ slightly, because the TLM side is searching by Target/Packet/Item, and CMD side is searching by only Target/Packet, but the code is very similar, and the functionality should appear the same to the user.

I didn't find any tests associated with the PacketViewer functionality, so I wasn't sure if anything needed to be updated for this request test-wise.

Aaron Jordan

@aaronatball aaronatball changed the title from Initial commit of development code to Add Search Bar to CmdSender Apr 13, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Apr 13, 2018

Codecov Report

Merging #771 into master will decrease coverage by 0.06%.
The diff coverage is 7.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #771      +/-   ##
==========================================
- Coverage   85.73%   85.67%   -0.07%     
==========================================
  Files         159      159              
  Lines       15026    15039      +13     
==========================================
+ Hits        12883    12884       +1     
- Misses       2143     2155      +12
Impacted Files Coverage Δ
lib/cosmos/packets/commands.rb 90.34% <7.69%> (-8.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c4f969...5a5dc91. Read the comment docs.

@@ -261,6 +261,28 @@ def clear_counters
end
end
# Returns an array with a "TARGET_NAME PACKET_NAME" string for every command in the system (PACKET_NAME == command name)
def all_item_strings(include_hidden = false, splash = nil)

This comment has been minimized.

@ryanatball

ryanatball Apr 17, 2018

Member

Please rename this to all_packet_strings. Otherwise looks good. Thanks!

This comment has been minimized.

@aaronatball

aaronatball Apr 17, 2018

Contributor

Done!

@ryanatball

This comment has been minimized.

Member

ryanatball commented Apr 17, 2018

👍

@ryanatball ryanatball merged commit db42215 into BallAerospace:master Apr 17, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment