queue multiple fcs #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with multiple reconfigurations
This reverts commit 1154b6d.
Queued FCs & JBController3_2 tests
…undingCyclesOf() in tests
… and not generally applicable
JBController3_2 Tests Refactor
xBA5ED
reviewed
Oct 25, 2023
| @@ -465,9 +505,19 @@ contract JBFundingCycleStore is JBControllerUtility, IJBFundingCycleStore { | |||
| // Get the necessary properties for the base funding cycle. | |||
| JBFundingCycle memory _baseFundingCycle = _getStructFor(_projectId, _fundingCycle.basedOn); | |||
|
|
|||
| // Find the base cycle that is not still queued. | |||
| while (_baseFundingCycle.start > block.timestamp) { | |||
There was a problem hiding this comment.
need a while (true) loop with a conditional here. i made the change.
Comment on lines
+538
to
+539
| while (_fundingCycle.number != 0) { | ||
| // If the latest is expired, return an empty funding cycle. |
| JBBallotState _ballotState = _ballotStateOf(_projectId, _fundingCycle); | ||
|
|
||
| // While the cycle has a ballot that isn't approved or if it hasn't yet started, get a reference to the funding cycle that the latest is based on, which has the latest approved configuration. | ||
| while ( |
| // Set the configuration. | ||
| configuration = _baseFundingCycle.configuration; | ||
| // Get the funding cycle for the configuration. | ||
| _fundingCycle = _getStructFor(_projectId, configuration); |
There was a problem hiding this comment.
configuration and _fundingCycle aren't needed in this loop, we can get these after we find the correct _baseFundingCycle.
There was a problem hiding this comment.
Isn't this the same as _fundingCycle = _baseFundingCycle;?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.