Adding StreamParam for StartStream #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuicyJ22
approved these changes
Sep 16, 2022
JuicyJ22
previously approved these changes
Sep 16, 2022
ajrice6713
previously approved these changes
Sep 16, 2022
ckoegel
reviewed
Sep 19, 2022
brianluisgomez
dismissed stale reviews from ajrice6713 and JuicyJ22
via
81eda77
Co-authored-by: Cameron Koegel <53310569+ckoegel@users.noreply.github.com>
bpateldx
reviewed
Sep 20, 2022
| /** | ||
| * <i>(optional)</i> You may specify up to 12 <StreamParam/> elements nested within a <StartStream> tag. These elements define optional user specified parameters that will be sent to the destination URL when the stream is first started. | ||
| */ | ||
| public StartStreamBuilder streamParams(List<StreamParam> streamParams){ |
There was a problem hiding this comment.
What's the rationale behind supporting two methods to set StreamParams?
bpateldx
approved these changes
Sep 20, 2022
ajrice6713
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.