Feature/deploy incremental #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
September 24, 2020 18:36
- update cli index - update deploy
|
Sorry, can you reopen this MR based on the main branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
Would have an adaptation for the Deploy CLI process.
Background was that I have a website where I upload up to 4000 files with each deployment.
The upload now, is suitable for the case with
< 1000files.With large amounts of data, many files are uploaded unnecessarily and consume the app quota (e.g. requests).
With the change from the PR there will be incremental upload.
Initially we will check which files have to be uploaded at all.
Important: For the incremental upload the
eTagandlastModifiedof the file objects will be used. Here it was missing the storage of both properties in the filelib/binding/File.js, if files were retrieved vialistFiles.There are two new options for the 'deploy' command.
--clean-up
If the
--clean-upoption is set, all unused files are removed from the bucket. Ideal for static pages where an HTML file disappears 馃檭--upload-limit
With the option
--upload-limitthe number of parallel uploads can be defined. Default is2.