Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force correct precedence in vmcs_intel_x64::check_host_verify_load_ia32_pat #215

Closed
cjams opened this issue Sep 20, 2016 · 2 comments
Closed

Force correct precedence in vmcs_intel_x64::check_host_verify_load_ia32_pat #215

cjams opened this issue Sep 20, 2016 · 2 comments
Assignees
@cjams
Labels
Type: Bug

Comments

@cjams
Copy link
Member

cjams commented Sep 20, 2016 •
edited
Loading

We need parentheses around the first two operands in each assignment statement to pat0 through pat7 in check_host_verify_load_ia32_pat. This will produce the intended behavior in the check.
cjams pushed a commit to cjams/hypervisor that referenced this issue Sep 20, 2016
Add fixes and tests for vmcs host checks
7a616d3 
This commit fixes issues Bareflank#211 and Bareflank#215 and implements unit tests
for vmcs_intel_x64_check_host.cpp.
@cjams cjams mentioned this issue Sep 20, 2016
Closed
@rianquinn
Copy link
Member

agreed

cjams pushed a commit to cjams/hypervisor that referenced this issue Sep 26, 2016
Add fixes and tests for vmcs host checks
6f0c5a0 
This commit fixes issues Bareflank#211 and Bareflank#215 and implements unit tests
for vmcs_intel_x64_check_host.cpp.
cjams pushed a commit to cjams/hypervisor that referenced this issue Sep 26, 2016
Add fixes and tests for vmcs host checks
3f09e2b 
This commit fixes issues Bareflank#211 and Bareflank#215 and implements unit
tests for vmcs_intel_x64_check_host.cpp
cjams pushed a commit to cjams/hypervisor that referenced this issue Sep 27, 2016
Add fixes and tests for vmcs host checks
a699fae 
This commit fixes issues Bareflank#211 and Bareflank#215 and implements unit
tests for vmcs_intel_x64_check_host.cpp.
cjams pushed a commit to cjams/hypervisor that referenced this issue Sep 30, 2016
Add fixes and tests for vmcs host checks
a54a00b 
This commit fixes issues Bareflank#211 and Bareflank#215 and implements
unit tests for vmcs_intel_x64_check_host.cpp
cjams pushed a commit to cjams/hypervisor that referenced this issue Sep 30, 2016
Add fixes and tests for vmcs host checks
4cba739 
This commit fixes issues Bareflank#211 and Bareflank#215 and implements
unit tests for vmcs_intel_x64_check_host.cpp.
cjams pushed a commit to cjams/hypervisor that referenced this issue Sep 30, 2016
Add fixes and tests for vmcs host checks
4c3fb2b 
This commit fixes issues Bareflank#211 and Bareflank#215 and implements
unit tests for vmcs_intel_x64_check_host.cpp.

It also moves helper functions such as enable_proc_ctl and
disable_proc_ctl to bfvmm/src/vmcs/test/test.h so
they are available for host and guest checks.
@cjams cjams mentioned this issue Sep 30, 2016
Merged
@cjams
Copy link
Member Author

cjams commented Oct 1, 2016

Fixed here #233

@cjams cjams closed this as completed Oct 1, 2016
@rianquinn rianquinn added this to the Bareflank Version 1.1 milestone Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjams cjams

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rianquinn @cjams