RDTSC Compilation Issue #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rianquinn
force-pushed
the
rdtsc_namespace_fix
branch
from
bfc54c3 to
4b17e17
Compare
The "__rdtsc" function name is taken by some code in GCC, which seems to collide on some 16.04 machines. This patch renames rdtsc to read_tsc. Signed-off-by: “Rian <“rianquinn@gmail.com”>
rianquinn
force-pushed
the
rdtsc_namespace_fix
branch
from
0b038dd to
86ce928
Compare
Contributor
|
+1, works for me :) |
Member
Author
|
@cjp256 merged |
cjp256
reviewed
Feb 13, 2017
| if [[ ! -d /cygdrive/c/ewdk ]]; then | ||
| echo "Fetching EWDK. Please wait..." | ||
| wget -nv -O /tmp/ewdk.zip "https://go.microsoft.com/fwlink/p/?LinkID=699461" | ||
| curl "https://go.microsoft.com/fwlink/p/?LinkID=699461" -L --output /tmp/ewdk.zip |
Contributor
There was a problem hiding this comment.
imo, something like local dl_path=$(mktemp) is the preferred approach over using hardcoded tmp paths... (or mktemp -d with the temp files within, that you can remove when finished).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "__rdtsc" function name is taken by some code in GCC,
which seems to collide on some 16.04 machines. This patch
renames rdtsc to read_tsc.
Signed-off-by: “Rian <“rianquinn@gmail.com”>