Skip to content

Fix invisible buttons on Memories empty state#6243

Merged
kodjima33 merged 1 commit into
mainfrom
worktree-voice-answers
Apr 1, 2026
Merged

Fix invisible buttons on Memories empty state#6243
kodjima33 merged 1 commit into
mainfrom
worktree-voice-answers

Conversation

@kodjima33
Copy link
Copy Markdown
Collaborator

Summary

  • White text + white background made buttons invisible in dark mode on the Memories page
  • "Add Your First Memory" and "Retry" buttons were completely hidden
  • Fixed by using purple background with white text (matches other CTAs in the app)

Test plan

  • Open Memories page with no memories — "Add Your First Memory" button should be visible (purple)
  • Trigger error state — "Retry" button should be visible (purple)

🤖 Generated with Claude Code

White background + white text made "Add Your First Memory" and "Retry"
buttons invisible. Switched to purple background with white text.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@kodjima33 kodjima33 merged commit 9644bd8 into main Apr 1, 2026
3 checks passed
@kodjima33 kodjima33 deleted the worktree-voice-answers branch April 1, 2026 06:11
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 1, 2026

Greptile Summary

This PR fixes a UI bug where the "Add Your First Memory" and "Retry" buttons on the Memories page were invisible in dark mode due to white text on a white background. The fix changes both buttons to use OmiColors.purplePrimary (#8B5CF6) as the background with white foreground text, matching the app's established CTA button style. The border overlay is also removed as it is no longer needed with the solid-colour background.

Changes:

  • Both buttons' backgrounds changed from Color.white to OmiColors.purplePrimary
  • Both buttons' foreground color changed from OmiColors.textPrimary to .white
  • Removed RoundedRectangle border overlay from both buttons (cleanup)
  • Styling is now consistent with other primary CTAs in the desktop app (e.g., OnboardingChatView, FileIndexingView)

Confidence Score: 5/5

Safe to merge — focused bug fix with no logic changes, only corrects button visibility styling.

The change is minimal (8 lines removed, 2 changed), directly addresses the described bug, and aligns with the established CTA style already used across the desktop app. No logic, data flow, or API contracts are affected. No new issues introduced.

No files require special attention.

Important Files Changed

Filename Overview
desktop/Desktop/Sources/MainWindow/Pages/MemoriesPage.swift Fixed invisible 'Add Your First Memory' and 'Retry' buttons by replacing white background + textPrimary text with purple background + white text; border overlay removed as well.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[MemoriesPage loads] --> B{State?}
    B -- No memories --> C[emptyStateView]
    B -- Load error --> D[errorView]
    B -- Searching no results --> E[noResultsView]
    B -- Loading --> F[loadingView]
    B -- Has memories --> G[Memory list]
    C --> H[Add Your First Memory button - purple background, white text]
    D --> I[Retry button - purple background, white text]
    H -->|Tap| J[showingAddMemory = true]
    I -->|Tap| K[viewModel.loadMemories]
Loading

Reviews (1): Last reviewed commit: "Fix invisible buttons on Memories empty ..." | Re-trigger Greptile

Glucksberg pushed a commit to Glucksberg/omi-local that referenced this pull request Apr 28, 2026
## Summary
- White text + white background made buttons invisible in dark mode on
the Memories page
- "Add Your First Memory" and "Retry" buttons were completely hidden
- Fixed by using purple background with white text (matches other CTAs
in the app)

## Test plan
- [ ] Open Memories page with no memories — "Add Your First Memory"
button should be visible (purple)
- [ ] Trigger error state — "Retry" button should be visible (purple)

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant