Cannot move around a zoomed image in 1.2.2 when it is placed inside ViewPager

[alvarolb]

In the latest version 1.2.2 the PhotoView behavior when it is placed inside a ViewPager is different from 1.2.1. In the previous version you can easily perform an image zoom and move around the image. In this new version, it is hard to move to the image bounds as the ViewPager is intercepting touch events and tries to switch page instead of moving inside zoomed image.

[smarek]

Hi @alvarolb, can you please test sample application from 1.2.2 (from current dev branch) ? There is ViewPager sample, just test that the issue is there too, and that it isn't specific to your application.
I've tested ViewPager works, and on my devices everything looks fine.

[alvarolb]

Hi @smarek I have tested the dev branch application sample and the problem is still there. It is easy to reproduce the issue, simply open ViewPager Sample, make a big zoom in the first image, and try to drag the zoomed image to left. Instead of moving image to left, the view pager switch the page to the next view. In the previous version 1.2.1 (available from play store) the image is dragged to left, and the view pager switch the view only when there is no more image available. I do not know if I am explaining it fine.

I am running Android 4.3

[smarek]

Oh, now I see it. I'll look into it, and possibly release mixup on github maven repository.

Hi @smarek I have tested the dev branch application sample and the problem is still there. It is easy to reproduce the issue, simply open ViewPager Sample, make a big zoom in the first image, and try to drag the zoomed image to left. Instead of moving image to left, the view pager switch the page to the next view. In the previous version 1.2.1 (available from play store) the image is dragged to left, and the view pager switch the view only when there is no more image available. I do not know if I am explaining it fine.

I am running Android 4.3

—
Reply to this email directly or view it on GitHub.

[alvarolb]

Thanks for your support @smarek 👍

[smarek]

@alvarolb can i ask you for testing?

[alvarolb]

yes @smarek, of course. Tell me what to do.

[smarek]

test using current dev branch, there is 15134e7 commit with possible fix. I don't have devices now by me.

[alvarolb]

Hi @smarek I have tested with the dev branch and the sample application, and now the library seems to work like before! thanks! Does this little fix will be merged with maven version? good work!

[smarek]

It will be released in 1.2.3, which is targeted on the end of week, I will release is it in maven snaphshot on github maven (see https://github.com/chrisbanes/PhotoView/tree/maven)

[alvarolb]

Perfect @smarek I am using already this maven snapshot, so I will wait for the next release ;)

[smarek]

Ok, the 1.2.3-SNAPSHOT is up, you can hook on it.

[laurencedawson]

Just grabbed the 1.2.3 snapshot and can confirm this has fixed the issue. Thanks for the update @smarek.

[DHuckaby]

@smarek Any update on when 1.2.3 will be released?

[smarek]

@DHuckaby not really, I've submitted it to Chrisfew weeks ago, he probably haven't got time to release it yet. You can probably use the snapshot provided in github maven branch until then.

[DHuckaby]

@smarek The currently snapshot works great. Can you reach back out to him please? I would prefer to reference a released version for a production build.