New "color framework" breaks text color #103

Closed
hmans opened this Issue Feb 13, 2012 · 4 comments

Comments

Projects
None yet
2 participants
Contributor

hmans commented Feb 13, 2012

Apparently, the new color framework introduced in 1da06a4 and 879d540 end up making all the normal text entered into and displayed by the shell appear "bold" (eg. apparently using the wrong escape code, or simply not resetting colors).

Things are fine in previous revisions. (I tested 54ffcc0.)

Contributor

hmans commented Feb 13, 2012

I'm happy to have a go at fixing this, but don't have the time for it at the moment, so maybe someone else can take over. Otherwise I can take a look at it some time during the upcoming weekend.

Edit: the two themes I tested this with are bobby and envy.

Owner

tswicegood commented Feb 14, 2012

Looking into this now. Here's a compare view of the things that changed:

87c989e...879d540

@berenm, if you have any ideas, please post them.

tswicegood added a commit that referenced this issue Feb 14, 2012

Revert new color framework
This still has some issues with it that need to be worked out.  See
ticket #103 for the current state.

This reverts commits:
* 1da06a4
* 879d540
Owner

tswicegood commented Feb 14, 2012

I've reverted the changes out in the above commit, but that doesn't address the underlying problem. I like the intent of @berenm's work, but it still needs some tweaking to make sure that everything's a go with all of the themes before merging back in.

tswicegood pushed a commit that referenced this issue Feb 14, 2012

Owner

tswicegood commented Feb 14, 2012

Closing this, as my local testing shows that it's now fixed. Thanks @berenm!

@tswicegood tswicegood closed this Feb 14, 2012

kevinjqiu pushed a commit to kevinjqiu/dot_bash that referenced this issue May 1, 2012

Revert new color framework
This still has some issues with it that need to be worked out.  See
ticket #103 for the current state.

This reverts commits:
* 1da06a4
* 879d540

kevinjqiu pushed a commit to kevinjqiu/dot_bash that referenced this issue May 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment