The installer is currently broken on my setup when selecting all. This patch should fix it. #151

Merged
merged 1 commit into from Aug 1, 2012

Conversation

Projects
None yet
2 participants
Contributor

chy-causer commented Jul 31, 2012

When selecting all, I get the following in my plugins/enabled directory

$ cd ~/.bash_it/plugins/enabled && ls -l
* -> ~/.bash_it/plugins/[^_]available/*

In other words, the regexp is not being expanded, and I don't think bash
has ever had this capability (I am running 4.2.24) . Looking at the commit
2443162, this line was added so as to disable
some plugins starting with a "_". In this circumstance, this line is
wrong anyway as it skips the directory "_available", rather than
available/_whatever.

This commit aims to fix this to the installer's intended purpose.
It also does a sanity check that no file exists already in enabled and
skips otherwise. ln -s does the right thing however more human error
message might be more desirable.

Chris Causer
Remove buggy line in install.sh causing "all" option to break
When selecting all, I get the following in my plugins/enabled directory

$ cd ~/.bash_it/plugins/enabled && ls -l
<snip fileinfo>          * -> ~/.bash_it/plugins/[^_]available/*

In other words, the regexp is not being expanded, and I don't think bash
has ever had this capability (I am running 4.2.24) . Looking at the commit
2443162, this line was added so as to disable
some plugins starting with a "_". In this circumstance, this line is
wrong anyway as it skips the directory "_available", rather than
available/_whatever.

This commit aims to fix this to the installer's intended purpose.
It also does a sanity check that no file exists already in enabled and
skips otherwise. ln -s does the right thing however more human error
message might be more desirable.

@ghost ghost assigned erichs Aug 1, 2012

Contributor

erichs commented Aug 1, 2012

Thanks! Much appreciated.

erichs added a commit that referenced this pull request Aug 1, 2012

Merge pull request #151 from ChrisCauser/master
The installer is currently broken on my setup when selecting all. This patch should fix it.

@erichs erichs merged commit 4de0b92 into Bash-it:master Aug 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment