Misc improvements #231
Misc improvements #231
Conversation
sultanqasim
commented
Sep 15, 2023
sultanqasim
commented
- More FFT timespan and waterfall update rate options
- Finer frequency resolution (larger FFT size) for panoramic spectrum to see narrower frequency peaks in wide frequency ranges
- Quicker GUI timer interval so that playback progress bar updates more smoothly (visually appealingly) on short recordings
- Properly handle setting the sample rate and center frequency when loading recordings for playback
- Fix some compiler warnings
When loading a new profile for a new file source, things like the sample rate may have changed from the current value that the rest of the UI was operating on. We need UIMediator to propagate these changes to the profile throughout the app, so we shouldn't clear the profile changed flags prematurely before the changes propagated.
Smoother scrolling time slider
librtlsdr zeroes out the tuner gain when calling rtlsdr_set_tuner_gain_mode with an R820T tuner. This is bad behaviour by librtlsdr, but to work around this, we can set the gain after setting AGC enablement status. Also, setting manual gain disables AGC for RTL-SDR, so only set manual gain when AGC is disabled. Also, always restore manual gain when AGC is disabled.
sultanqasim
force-pushed
the
misc_improvements
branch
from
fdf05d6
to
ea13efa
Compare
|
Looks good too, will test it along with your PR for suscan. Thanks! |
|
There's a little UI issue with these changes in the Source config tab (ProfileConfigTab). If you attempt to navigate through all source types with the mouse wheel or the arrow keys, sometimes the current source type is not reflected in the source type combo / source config UI stack (although it does in the ProfileConfigTab state and the underlying Suscan::Source::Config object). |
|
Thanks for your testing, I’ll look into that bug |
|
@BatchDrake you need some help with those failing tests? |
|
Hi, I plan to get back to this soon, but I am afraid I will not find time until the week of December 18th or so. Cheers, |
|
I need to recreate the bug BatchDrake encountered regarding ProfileConfigTab and then find the root cause. Maybe I’ll have time this week. |
|
Fixed. It had to do with signals being emitted at the wrong time (source config widget activation). I've just prevented this explicitly. |
|
Thanks for figuring this out! Sorry, I haven’t gotten to spend much time on SigDigger lately though I’m still hoping to get back to it soon. |
|
No worries, I was waiting for a 3D print to finish and decided to close as
many PRs as possible today :)
El sáb., 20 ene. 2024 21:07, Sultan Qasim Khan ***@***.***>
escribió:
… Thanks for figuring this out! Sorry, I haven’t gotten to spend much time
on SigDigger lately though I’m still hoping to get back to it soon.
—
Reply to this email directly, view it on GitHub
<#231 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEVETYYDDMSZ65FLLIC2BTYPQPZXAVCNFSM6AAAAAA4ZMUXACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGI2TIMJSHA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
