From 82b2da4c47797cb62baea960d17a67cb374e5e9c Mon Sep 17 00:00:00 2001 From: Nikita Titov Date: Mon, 13 Apr 2020 19:51:02 +0300 Subject: [PATCH] Support Python 3.8 (#191) --- .travis.yml | 1 + requirements-test.txt | 18 +++++++++--------- setup.py | 1 + tests/utils.py | 2 +- 4 files changed, 12 insertions(+), 10 deletions(-) diff --git a/.travis.yml b/.travis.yml index 3c099ccc..7b70f7f5 100644 --- a/.travis.yml +++ b/.travis.yml @@ -5,6 +5,7 @@ python: - 3.5 - 3.6 - 3.7 + - 3.8 env: - TEST=API diff --git a/requirements-test.txt b/requirements-test.txt index d5261278..addacee1 100644 --- a/requirements-test.txt +++ b/requirements-test.txt @@ -1,13 +1,13 @@ -numpy==1.16.1 -scipy==1.1.0 -scikit-learn==0.20.2 +numpy==1.18.2 +scipy==1.4.1 +scikit-learn==0.22.2.post1 xgboost==1.0.2 -lightgbm==2.2.3 -flake8==3.6.0 -pytest==5.3.2 -pytest-mock==1.13.0 -coveralls==1.9.2 +lightgbm==2.3.1 +flake8==3.7.9 +pytest==5.4.1 +pytest-mock==3.0.0 +coveralls==2.0.0 pytest-cov==2.8.1 -py-mini-racer==0.1.18 +py-mini-racer==0.2.0 statsmodels==0.11.1 git+git://github.com/scikit-learn-contrib/lightning.git@b96f9c674968496e854078163c8814049a7b9f43 diff --git a/setup.py b/setup.py index e172d259..dd0c8642 100644 --- a/setup.py +++ b/setup.py @@ -28,6 +28,7 @@ "Programming Language :: Python :: 3.5", "Programming Language :: Python :: 3.6", "Programming Language :: Python :: 3.7", + "Programming Language :: Python :: 3.8", "Programming Language :: Python :: Implementation :: CPython", ], keywords="sklearn ml code-generation", diff --git a/tests/utils.py b/tests/utils.py index 8644bcd0..af926a1e 100644 --- a/tests/utils.py +++ b/tests/utils.py @@ -218,7 +218,7 @@ def predict_from_commandline(exec_args): result = subprocess.Popen(exec_args, stdout=subprocess.PIPE, stderr=subprocess.PIPE) stdout, stderr = result.communicate() - if result.returncode is not 0: + if result.returncode != 0: raise Exception("bad exit code ({}) stderr: {}".format( result.returncode, stderr.decode("utf-8")))