Context-Based: Grab Intent [READY FOR REVIEW] #8722

Hubblenaut · 2015-04-02T20:39:33Z

Context-Based Combat: Grab Intent

Basic grab redesign including special grab actions proposed by the community.

Changes:

Grab animations
New grab icons
Pushing

Features:

Details

Feature	Description	Trigger	Required	Target
Jointlocking	Causes 40 halloss	Click on victim with harm intent	Neck grab	Limb
Jointbreaking	Dislocates the limb	Click on victim with harm intent	Neck grab	Limb
Eyesquishing	Causes 3 to 4 eye damage	Click on victim with harm intent	Neck grab	Eyes
Knifing	Causes 60 brute (divided into 3*20) and 60 oxyloss	Attack the victim with an edged item	Neck grab	Head
Headbutting	Causes 20 damage to victim and 10 damage to assailant	Click on victim with harm intent	Aggressive grab	Head
Pinning	Pins victim to the ground	Click on victim with disarm intent	Aggressive grab	n/A
Blinding	Victim can't see	Target eyes	Aggressive grab	Eyes
Muzzling	Victim can't speak	Target mouth	Aggressive grab	Mouth
Dancing	Constantly facing each other	Two people grabbing each other	n/A	n/A
Buckling	Buckles the grabbed person to an object	Click on object	n/A	n/A

Screenshots

Grab Transition Animations

Appearance in Chatbox

comma · 2015-04-02T20:40:32Z

Corpses probably work already as meatshields if you neckgrab them.

mwerezak · 2015-04-02T21:53:08Z

They do for projectiles. Melee and thrown items not yet.

Conflicts: icons/mob/screen1.dmi

mwerezak · 2015-05-07T01:14:56Z

code/modules/mob/mob_grab.dm

+					var/armor = affecting:run_armor_check(affecting, "melee")
+					if(armor < 2)
+						affecting << "<span class='danger'>You feel extreme pain!</span>"
+						affecting.apply_damage(40, HALLOSS, last_hit_zone, armor)


Can this be done repeatedly? I'm not certain, but if it can it may be possible to knock someone out for a very long time by spamming this, which could be unfun.

The force down keeps them on the floor for as long as the grab is active, but afaik it should still be managable to resist out. Not sure, though, will check to be certain.

I was thinking more about spamming jointlock. I just checked human Life code and it looks like halloss is capped to 100, so it's not as bad as I originally thought.

Still, hitting 100 halloss makes you unable to see/hear/talk and prevents resisting for 10 seconds, so it might be a good idea to limit the number of times that this can be done, or something. I was going to suggest perhaps limiting it to once per organ, but I don't know if that makes sense for jointlocking.

Another idea would be to only apply more halloss if they are under 80 or some other number. This would mean that people can never pass out from jointlocking, which may or may not be desirable, since really we only want to prevent people from being permanently passed out.

I will change it so that 40 halloss is as much as it can possibly inflict.

mwerezak · 2015-05-07T04:56:59Z

It might be a good idea to have delays associated with some these actions, jointlocking, jointbreaking, eyesquishing, and knifing in particular.

Have you considered adding a bonus for sharp unarmed attacks to eyesquishing? I'm not sure how feasible it would be to implement it cleanly but it would be a nice touch.

Now that there are many ways to really fuck someone up once you have a neck grab on them, I think you may want to consider changing neck grabs to give a one-time 5-10 second stun once achieved (giving you a brief period to make special grab attacks on the victim), instead of a permastun.

mwerezak · 2015-05-07T04:58:56Z

code/_onclick/item_attack.dm

@@ -25,6 +25,21 @@

 	if(!istype(M) || (can_operate(M) && do_surgery(M,user,src))) return 0

+	// Knifing
+	if(edge)


It would be cleaner to move this into /obj/item/weapon/grab/attack() and check the inactive hand for an edge weapon instead of sticking it in the middle of click code.

I think that might be counterintuitive for a player, having to click the victim with the grab to slit him with the knife of the inactive hand.

Yeah, I can understand that.

If values above 23.3 with edge/sharp wouldn't cut off limbs, the three inflicted wounds could be merged into one and I'd make it dependant on the weapon's force value.
However as long as there's a guaranteed chance of the head coming off immediately, I will keep the damage dealt by knifing static to avoid that.

Well it's not guaranteed, it's governed by prob(brute), though I can see why you would want to avoid it.

I think applying a small amount of damage several times is actually a good way to model knifing. From my impression of the way wounding works, dealing a lot of damage at once seems to be treated as hitting with a lot of momentum (like a sword swing).

It might be worth considering something like:

for(var/i in 1 to 6) M.apply_damage(min(force/2, 20), BRUTE, "head", 0, sharp=sharp, edge=edge)

What you have is fine though.

Also I think there's a parameter for apply_damage() that is needed to generate proper autopsy logs, might be a good idea to check that.

Roland410 · 2015-05-07T18:35:32Z

A way to change to bodyparts faster would be appreciated to this, since using the damage location interface while trying to jointlock and muzzle is pretty bad.

Hubblenaut · 2015-05-07T18:58:03Z

That's not a new problem and I doubt I will be able to think of a way to make changing the target organs more convenient, sorry.

Roland410 · 2015-05-07T19:21:44Z

I guess using the numpad isn't an option then, right?

Hubblenaut · 2015-05-10T15:14:40Z

I'll remove the knifing ability if devs find it too snowflakey/gamebreaking and there is no good codewise way to improve it.

Merge conflict will be fixed after all other changes were made.

…ing and forcing onto the floor fixup

mwerezak · 2015-05-11T04:41:40Z

Knifing adds the possibility of holding someone hostage with a melee weapon, which currently is more or less solely the domain of guns, so I think it's a good thing to have. It looks like there was some controversy over it in the paracode port but honestly I don't see those concerns being an issue here.

If you get someone into a neck grab and then cut their throat yeah you can kill them pretty fast. That's not really a surprise. Now in combination with the other things in this PR maybe there could be a problem. If it turns out that getting an aggressive grab -> pinning -> using the pin to escalate to neck grab -> slitting their throat is too easy to do without giving your opponent a chance to react it may have to be tweaked, but it probably is too early to tell at this point without playtesting.

Really it's pinning that concerns me more than knifing, but Weaken(3) seems fairly short so we will have to see.

Also it might need some further polishing like taking into account armour, weapons with very low force values, etc.

Also I am still a bit concerned about spamming all these debilitating attacks on someone once you get the appropriate grab on them, completely fucking them over very fast. You might want to consider adding do_after() timers for some of these things (Eyesquishing and Joint Dislocating in particular), if you haven't already. I may tweak some things once this is merged.

Hubblenaut · 2015-05-11T13:50:29Z

Joint dislocating already has a do_after() and any action on the victim will reset the time one needs to upgrade the grab.

I may add a do_after to pinning down.

mwerezak · 2015-05-11T14:08:04Z

Yeah, just wanted to bring up some things to think about. I'd feel far less worried about pinning if it could be made to not prevent resisting somehow.

comma · 2015-05-12T12:21:18Z

Well, that delay on pinning might be nice (because downing someone is a win in SS13 combat), but otherwise looks all good
👍

Conflicts: code/game/objects/structures/stool_bed_chair_nest/bed.dm code/modules/mob/mob_grab.dm

comma · 2015-05-12T14:51:39Z

adds delay to pinning

Did you forget to commit the file? Seeing only dmi change in that commit.

Hubblenaut · 2015-05-12T15:00:38Z

Fixed.

Context-Based: Grab Intent [READY FOR REVIEW]

Hubblenaut added 2 commits April 1, 2015 19:07

Grab Basics

ea49978

New Icons

9730f24

Merge branch 'grab' into dev

a40ef85

Conflicts: icons/mob/screen1.dmi

Hubblenaut force-pushed the dev branch from 7f1c861 to a40ef85 Compare April 19, 2015 14:03

Adds blinding/muzzling and changes trigger for jointbreaking

8528948

mwerezak reviewed May 7, 2015
View reviewed changes

Hubblenaut force-pushed the dev branch 2 times, most recently from 16397ba to bebc6fa Compare May 8, 2015 13:13

tigercat2000 mentioned this pull request May 9, 2015

Context-Based: Grab Intent (Bayport) ParadiseSS13/Paradise#981

Merged

Adds knifing, pressing eyes, jointlocking, headbutting, pushing, danc…

fb8812d

…ing and forcing onto the floor fixup

Hubblenaut force-pushed the dev branch from bebc6fa to fb8812d Compare May 10, 2015 15:54

Hubblenaut changed the title ~~Context-Based: Grab Intent [DO NOT MERGE YET]~~ Context-Based: Grab Intent [READY FOR REVIEW] May 10, 2015

MistakeNot4892 added feature labels May 11, 2015

comma removed the needs review label May 12, 2015

Merge remote-tracking branch 'upstream/dev' into dev

1b3ddb8

Conflicts: code/game/objects/structures/stool_bed_chair_nest/bed.dm code/modules/mob/mob_grab.dm

comma removed the cannot merge label May 12, 2015

Final adjustments to icons, adds delay to pinning

32b4632

Hubblenaut force-pushed the dev branch from 280b21c to 32b4632 Compare May 12, 2015 15:21

comma added a commit that referenced this pull request May 12, 2015

Merge pull request #8722 from Hubblenaut/dev

c15c69b

Context-Based: Grab Intent [READY FOR REVIEW]

comma merged commit c15c69b into Baystation12:dev May 12, 2015

Fox-McCloud mentioned this pull request May 10, 2016

Grab fixes + Blinding ParadiseSS13/Paradise#4412

Closed

Hubblenaut mentioned this pull request Jul 12, 2017

Grab features missing from rewrite. #17804

Closed

5 tasks

babydoll removed the refactor♻ label Jun 16, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Context-Based: Grab Intent [READY FOR REVIEW] #8722

Context-Based: Grab Intent [READY FOR REVIEW] #8722

Hubblenaut commented Apr 2, 2015

comma commented Apr 2, 2015

mwerezak commented Apr 2, 2015

mwerezak May 7, 2015

Hubblenaut May 7, 2015

mwerezak May 7, 2015

Hubblenaut May 7, 2015

mwerezak commented May 7, 2015

mwerezak May 7, 2015

Hubblenaut May 7, 2015

mwerezak May 7, 2015

Hubblenaut May 8, 2015

mwerezak May 8, 2015

Roland410 commented May 7, 2015

Hubblenaut commented May 7, 2015

Roland410 commented May 7, 2015

Hubblenaut commented May 10, 2015

mwerezak commented May 11, 2015

Hubblenaut commented May 11, 2015

mwerezak commented May 11, 2015

comma commented May 12, 2015

comma commented May 12, 2015

Hubblenaut commented May 12, 2015

Context-Based: Grab Intent [READY FOR REVIEW] #8722

Context-Based: Grab Intent [READY FOR REVIEW] #8722

Conversation

Hubblenaut commented Apr 2, 2015

Context-Based Combat: Grab Intent

Details

Screenshots

comma commented Apr 2, 2015

mwerezak commented Apr 2, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mwerezak commented May 7, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Roland410 commented May 7, 2015

Hubblenaut commented May 7, 2015

Roland410 commented May 7, 2015

Hubblenaut commented May 10, 2015

mwerezak commented May 11, 2015

Hubblenaut commented May 11, 2015

mwerezak commented May 11, 2015

comma commented May 12, 2015

comma commented May 12, 2015

Hubblenaut commented May 12, 2015