New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function name clashes with WordPress 4.4 #5

Closed
Screenfeed opened this Issue Oct 25, 2015 · 6 comments

Comments

Projects
None yet
2 participants
@Screenfeed

Screenfeed commented Oct 25, 2015

Hi there.

Here what I spotted so far: update_termmeta_cache(), add_term_meta(), delete_term_meta(), get_term_meta() and update_term_meta().
But the worst part is that we also have non-matching function signatures: the plugin functions use $taxonomy as first parameter, but WordPress doesn't.

@herewithme

This comment has been minimized.

Member

herewithme commented Oct 25, 2015

SHIT !

@Screenfeed

This comment has been minimized.

Screenfeed commented Oct 25, 2015

?

@herewithme

This comment has been minimized.

Member

herewithme commented Oct 25, 2015

No solution is really possible ... Edit behavioral functions break the compat, the arrival of WP 4.4, makes it incompatible my implementation.

Anyway, crap.

@Screenfeed

This comment has been minimized.

Screenfeed commented Oct 25, 2015

I guess the only thing would be this at the beginning of the plugin:
if ( function_exists( 'get_term_meta' ) { return; }
Things would break because of the non-matching function signatures, but not trigger a fatal error.

@herewithme

This comment has been minimized.

Member

herewithme commented Oct 26, 2015

Hop !
d59dd5b

@herewithme herewithme closed this Oct 26, 2015

@Screenfeed

This comment has been minimized.

Screenfeed commented Oct 26, 2015

Easy pizi ^^'
Would me too much to ask an update on the WordPress repository? :3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment