Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Line Wallet and Node - Inconsistent param names #249

Closed
azaidelson opened this Issue Dec 30, 2018 · 3 comments

Comments

Projects
6 participants
@azaidelson
Copy link

commented Dec 30, 2018

In CLI wallet, there are operations called export_miner_key and export_owner_key

In Node, the corresponding parameters are called key_mine and key_owner, respectively

For consistency, they should be named miner_key and owner_key in the Node

@gingervik gingervik added this to To Do in Backlog via automation Jan 18, 2019

@beam-mw

This comment has been minimized.

Copy link
Member

commented Feb 24, 2019

Do not remove old names, Add new ones as alias

@beam-mw beam-mw removed this from To Do in Backlog Feb 24, 2019

@beam-mw beam-mw added this to To do in Bright Boson 2.1 via automation Feb 24, 2019

@sasha-abramovich sasha-abramovich assigned echoby and unassigned anatolse Mar 21, 2019

echoby added a commit that referenced this issue Mar 22, 2019

@echoby echoby moved this from To do to Done in Bright Boson 2.1 Mar 22, 2019

@gingervik gingervik added this to To do in Bright Boson 2.0 via automation Mar 25, 2019

@gingervik gingervik removed this from Done in Bright Boson 2.1 Mar 25, 2019

@gingervik gingervik moved this from To do to Done in Bright Boson 2.0 Mar 25, 2019

@jurijakimuk jurijakimuk assigned jurijakimuk and unassigned echoby Mar 25, 2019

@jurijakimuk

This comment has been minimized.

Copy link
Member

commented Mar 25, 2019

@echoby Please, change the following texts:
"key_owner" parameter was deprecated, use "owner_key"
to
The "key_owner" parameter is deprecated, use "owner_key" instead.
and
"key_mine" parameter was deprecated, use "miner_key"
to
The "key_mine" parameter is deprecated, use "miner_key" instead.

@jurijakimuk jurijakimuk assigned echoby and jurijakimuk and unassigned jurijakimuk Mar 25, 2019

echoby added a commit that referenced this issue Mar 25, 2019

@jurijakimuk

This comment has been minimized.

Copy link
Member

commented Mar 25, 2019

Tested on 4661, master. Works OK.

Bright Boson 2.0 automation moved this from Done to Tested Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.