New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet API enhancements #306

Closed
nesbox opened this Issue Jan 8, 2019 · 20 comments

Comments

Projects
3 participants
@nesbox
Copy link
Member

nesbox commented Jan 8, 2019

No description provided.

@nesbox nesbox added the enhancement label Jan 8, 2019

@alesito85

This comment has been minimized.

Copy link

alesito85 commented Jan 8, 2019

  • tx history (with confirmations)
  • wallet lock/unlock
  • list of locked UTXO
  • cancel tx
  • add confirmations to status
@feeleep75

This comment has been minimized.

Copy link

feeleep75 commented Jan 17, 2019

please add tx_send option ASAP :)

@nesbox

This comment has been minimized.

Copy link
Member Author

nesbox commented Jan 17, 2019

https://github.com/BeamMW/beam/wiki/Beam-wallet-protocol-API#tx_send
tx_send already added, or what do you mean? pls explain
thanks

please add tx_send option ASAP :)

@feeleep75

This comment has been minimized.

Copy link

feeleep75 commented Jan 17, 2019

every single time I was trying to send - transaction failed. It generates the transaction but with kernel '000000...' and after some time status is failed. Node was running and wallet in listen mode - maybe I am doing something wrong?

@gingervik gingervik added this to To do in Agile Atom 1.2 via automation Jan 18, 2019

@nesbox

This comment has been minimized.

Copy link
Member Author

nesbox commented Jan 18, 2019

@feeleep75 could you please provide us wallet/api/node logs with failed transactions?
thank you

@feeleep75

This comment has been minimized.

Copy link

feeleep75 commented Jan 18, 2019

with pleasure, but tell me - is it an easy way to log into file?

@feeleep75

This comment has been minimized.

Copy link

feeleep75 commented Jan 18, 2019

Here you are (I removed IP and address):

API:

E 2019-01-18.09:32:53.098 on_new_message int(type)=0 ret=0
D 2019-01-18.09:32:53.351 +peer x.x.x.x:49586
D 2019-01-18.09:32:53.351 on_stream_accepted
I 2019-01-18.09:32:53.351 got {"jsonrpc":"2.0","id":2,"method":"tx_send","params":{"value":10000000,"fee":2,"address":"xxx","comment":"test"}}

D 2019-01-18.09:32:53.351 Send(id = 2 amount = 10000000 fee = 2 address = xxx)
I 2019-01-18.09:32:53.394 WalletID 59cc4de838b92bd059d3e08e78356d420185d5959f4b700ae86907a2a9feeead43 subscribes to BBS channel 89
I 2019-01-18.09:32:53.432 [e13fee00c2f0498ea12ec69ac2d97ded] Sending 10000000 groth  (fee: 2 groth )
I 2019-01-18.09:32:53.544 [e13fee00c2f0498ea12ec69ac2d97ded] Invitation accepted
I 2019-01-18.09:32:53.613 peer disconnected, code=EC_EOF
I 2019-01-18.09:32:53.863 got {"jsonrpc":"2.0","id":123,"method":"wallet_status","params":{}}

D 2019-01-18.09:32:53.863 WalletStatus(id = 123)

Node:
I 2019-01-18.09:32:50.932 Peer 118.31.229.178:10000 Tip: 21348-d6a8078524e0e207
I 2019-01-18.09:32:50.933 21348-d6a8078524e0e207 Header accepted
I 2019-01-18.09:32:50.933 PI a4c46da6537ed1bb--118.31.229.178:10000 Rating 10240 -> 10240
I 2019-01-18.09:32:50.933 Requesting block 21348-d6a8078524e0e207
I 2019-01-18.09:32:50.938 Peer 47.111.23.142:10000 Tip: 21348-d6a8078524e0e207
I 2019-01-18.09:32:51.143 PI a4c46da6537ed1bb--118.31.229.178:10000 Rating 10240 -> 10240
I 2019-01-18.09:32:51.143 21348-d6a8078524e0e207 Block received
I 2019-01-18.09:32:51.144 21348-d6a8078524e0e207 Block interpreted. Fwd=1
I 2019-01-18.09:32:51.144 My Tip: 21348-d6a8078524e0e207, Work = 2.28994e+12
I 2019-01-18.09:32:51.144 GenerateNewBlock: size of block = 296; amount of tx = 0
I 2019-01-18.09:32:51.144 Block generated: Height=21349, Fee=0, Waiting for owner response...
I 2019-01-18.09:32:51.158 Block Finalized by owner
I 2019-01-18.09:32:51.158 Block generated: Height=21349, Fee=0, Difficulty=1a-1718f7(7.31637e+07), Size=296
I 2019-01-18.09:32:51.158 New job for external miner
I 2019-01-18.09:32:51.158 stratum server new job 29 will be sent to 0 connected peers
D 2019-01-18.09:32:51.296 New peer connected: 127.0.0.1:10000
I 2019-01-18.09:32:51.297 +Peer 127.0.0.1:42848
W 2019-01-18.09:32:51.297 127.0.0.1:42848: end of file
I 2019-01-18.09:32:51.297 -Peer 127.0.0.1:42848
D 2019-01-18.09:32:53.097 New peer connected: 127.0.0.1:10000
I 2019-01-18.09:32:53.097 +Peer 127.0.0.1:42926
I 2019-01-18.09:32:53.098 Peer 127.0.0.1:42926 Connected
E 2019-01-18.09:32:53.098 on_new_message int(type)=0 ret=0
D 2019-01-18.09:32:58.099 New peer connected: 127.0.0.1:10000
I 2019-01-18.09:32:58.099 +Peer 127.0.0.1:43162
I 2019-01-18.09:32:58.100 Peer 127.0.0.1:43162 Connected

Wallet:
I 2019-01-18.09:32:51.157 Sync up to 21348-d6a8078524e0e207
I 2019-01-18.09:32:51.157 Synchronizing with node: 0% (0/1)
I 2019-01-18.09:32:51.163 Synchronizing with node: 100% (1/1)
I 2019-01-18.09:32:51.176 Current state is 21348-d6a8078524e0e207
I 2019-01-18.09:33:30.911 Sync up to 21349-4ad30c2055c61a16
I 2019-01-18.09:33:30.912 Synchronizing with node: 0% (0/1)
I 2019-01-18.09:33:30.923 Synchronizing with node: 100% (1/1)
I 2019-01-18.09:33:30.939 Current state is 21349-4ad30c2055c61a16
@nesbox

This comment has been minimized.

Copy link
Member Author

nesbox commented Jan 18, 2019

could you provide full logs, just zip them and attach to the issue
thank you

@feeleep75

This comment has been minimized.

Copy link

feeleep75 commented Jan 18, 2019

It does not change anything... you will just get more logs but here you are. BTW - when I restarted the wallet you can see info about transaction expired from my previous comment :)
beam-api.log.zip
beam-node.log.zip
beam-wallet.log.zip

@nesbox

This comment has been minimized.

Copy link
Member Author

nesbox commented Jan 18, 2019

As I see you have different signatures
Rules signature: 7c360d0c2ee92d9e in api
Rules signature: ed91a717313c6eb0 in node
Rules signature: ed91a717313c6eb0 in wallet
they should be the same.
so, where and how did you download/build the binaries?
Thanks

@feeleep75

This comment has been minimized.

Copy link

feeleep75 commented Jan 18, 2019

hmm - I built wallet-api - the rest if from latest release

@nesbox

This comment has been minimized.

Copy link
Member Author

nesbox commented Jan 18, 2019

maybe you used different branches, master or mainnet?

@feeleep75

This comment has been minimized.

Copy link

feeleep75 commented Jan 18, 2019

master

@feeleep75

This comment has been minimized.

Copy link

feeleep75 commented Jan 18, 2019

I can build but now sure if the vulnerability has been fixed already in source

@nesbox

This comment has been minimized.

Copy link
Member Author

nesbox commented Jan 18, 2019

your wallet and node work on mainnet, while api works in masternet
pls use mainnet for api too https://github.com/BeamMW/beam/tree/mainnet

@feeleep75

This comment has been minimized.

Copy link

feeleep75 commented Jan 18, 2019

compiled from main net branch and still the same issue

@nesbox

This comment has been minimized.

Copy link
Member Author

nesbox commented Jan 18, 2019

full logs please

@feeleep75

This comment has been minimized.

Copy link

feeleep75 commented Jan 18, 2019

sorry - my fault - it works now. Thank you for helping!

@nesbox

This comment has been minimized.

Copy link
Member Author

nesbox commented Jan 18, 2019

ok, great, thank you

@nesbox

This comment has been minimized.

Copy link
Member Author

nesbox commented Jan 22, 2019

I close this issue as a duplicate of #76, also utxo lock/unlock will be implemented there too.

@nesbox nesbox closed this Jan 22, 2019

Agile Atom 1.2 automation moved this from To do to Tested Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment