New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mining threads from wallets #361

Closed
gingervik opened this Issue Jan 17, 2019 · 5 comments

Comments

Projects
4 participants
@gingervik
Copy link
Member

gingervik commented Jan 17, 2019

Remove cpu mining threads from wallets and make mining_threads=0 (UI and Wallet)

@sasha-abramovich

This comment has been minimized.

Copy link
Contributor

sasha-abramovich commented Jan 22, 2019


image

@alexandrashelenkova currently under the local node many GPUs can be listed. They will stay even after the mining threads will be removed.

@Aleksandr-Starun Aleksandr-Starun moved this from To do to In progress in Agile Atom 1.2 Jan 23, 2019

@alexandrashelenkova

This comment has been minimized.

Copy link

alexandrashelenkova commented Jan 28, 2019

Updated screenshots are here
zpl.io/blPjJe1
zpl.io/25wnmjJ

@gingervik

This comment has been minimized.

Copy link
Member Author

gingervik commented Jan 31, 2019

@alexandrashelenkova @sasha-abramovich sorry guys, but where is cards names in your screenshots? user should be able to select which ones he want to use for mining
also we need a warning that he has not supported GPU cards

@sasha-abramovich

This comment has been minimized.

Copy link
Contributor

sasha-abramovich commented Feb 5, 2019

As for now, let's just remove the mining slider and leave the rest of the design "as is".

Our UX in zeplin doesn't include GPU support on purpose, but the actual decision was not made meanwhile. We'll adjust it later.

@gingervik gingervik moved this from In progress to Done in Agile Atom 1.2 Feb 7, 2019

@gingervik

This comment has been minimized.

Copy link
Member Author

gingervik commented Feb 7, 2019

checked. mining threads are removed. default = 0

@gingervik gingervik closed this Feb 7, 2019

Agile Atom 1.2 automation moved this from Done to Tested Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment