Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment proof in UI wallet #415

Closed
gingervik opened this Issue Jan 28, 2019 · 10 comments

Comments

6 participants
@gingervik
Copy link
Member

gingervik commented Jan 28, 2019

  1. We need add payment proof in Transaction details for outgoing transactions (only in sender wallet)
    Command for cli wallet: beam-wallet.exe payment_proof_export --tx_id=

Output for Payment proof: 4bd0ca080bd8c3ec4b3061bf5
916aa34266f0649a7c151c6777ffe492f15e0976800000000000000ebb27b5501213c84eb212ea27
6e8ced74f540fbcceb0f4c1c2da2c5108188651a1864ac2f195ce9056c171fd0cd41e8a02dc9c0bb
72861b2e03fbbbb5942e5e63d1a7728a2954a10d3bfb9938f0c17509a6a0e870c6bb22ff2d1297f3
dae7f54592b00e84c6b3c9ea3e3ad9bc43661b6dcf7dbd818ccc92707d1d75b429697e8492653

2.Receiver should have ability to decode (verify) proof from sender
Command for cli wallet: beam-wallet.exe payment_proof_verify --payment_proof=

Output for verifying:
Payment tx details:
Sender: 4bd0ca080bd8c3ec4b3061bf5916aa34266f0649a7c151c6777ffe492f15e09768
Receiver: ebb27b5501213c84eb212ea276e8ced74f540fbcceb0f4c1c2da2c5108188651a1
Amount: 6 groth
KernelID: 4ac2f195ce9056c171fd0cd41e8a02dc9c0bb72861b2e03fbbbb5942e5e63d1a

@sasha-abramovich please, provide design for all this stuff

@gingervik gingervik added this to To do in Bright Boson 2.0 via automation Jan 28, 2019

@sasha-abramovich

This comment has been minimized.

Copy link
Contributor

sasha-abramovich commented Feb 14, 2019

@anatolse anatolse moved this from To do to In progress in Bright Boson 2.0 Feb 18, 2019

@anatolse anatolse closed this Feb 18, 2019

Bright Boson 2.0 automation moved this from In progress to Tested Feb 18, 2019

@anatolse anatolse reopened this Feb 18, 2019

Bright Boson 2.0 automation moved this from Tested to To do Feb 18, 2019

@anatolse anatolse moved this from To do to In progress in Bright Boson 2.0 Feb 18, 2019

anatolse added a commit that referenced this issue Feb 22, 2019

@anatolse anatolse moved this from In progress to Done in Bright Boson 2.0 Feb 22, 2019

valdok added a commit that referenced this issue Feb 22, 2019

@gingervik

This comment has been minimized.

Copy link
Member Author

gingervik commented Feb 24, 2019

  1. only outgoing transactions should have Payment proof
    image

  2. Copy button does nothing
    image

- click on proof verification icon
- insert proof code
- close proof verification window
- open it again

Result: image

  1. Copy details button does not work as expected
    image

  2. Cursor should be placed in field automatically
    image

@gingervik gingervik assigned anatolse and unassigned Sergei-Beam Feb 24, 2019

@gingervik gingervik moved this from Done to To do in Bright Boson 2.0 Feb 24, 2019

@anatolse anatolse moved this from To do to In progress in Bright Boson 2.0 Feb 25, 2019

anatolse added a commit that referenced this issue Feb 25, 2019

@anatolse anatolse moved this from In progress to Done in Bright Boson 2.0 Feb 25, 2019

@Sergei-Beam

This comment has been minimized.

Copy link
Member

Sergei-Beam commented Feb 25, 2019

  1. layout moves out
    6.1 Payment proof dialog window
    Steps:
  • click on proof verification icon
  • insert proof code
  • delete the last number
    image
  • type the deleted number again
    Actual: layout moves out
    image

6.2 Transaction information -proof buttons partially hidden
image

anatolse added a commit that referenced this issue Feb 25, 2019

@Sergei-Beam Sergei-Beam moved this from Done to To do in Bright Boson 2.0 Feb 26, 2019

@Sergei-Beam

This comment has been minimized.

Copy link
Member

Sergei-Beam commented Feb 26, 2019

  1. @anatolse please change the error message according to design
    https://zpl.io/VYKwnoL

@anatolse anatolse moved this from To do to In progress in Bright Boson 2.0 Feb 27, 2019

@gingervik

This comment has been minimized.

Copy link
Member Author

gingervik commented Mar 4, 2019

8 - checked

  1. For expired or Not finished transaction we should not show details and copy buttons (no payment proof - no buttons)
    image

@gingervik gingervik moved this from Done to To do in Bright Boson 2.0 Mar 4, 2019

@anatolse anatolse moved this from To do to In progress in Bright Boson 2.0 Mar 5, 2019

anatolse added a commit that referenced this issue Mar 5, 2019

@anatolse anatolse moved this from In progress to Done in Bright Boson 2.0 Mar 5, 2019

@gingervik

This comment has been minimized.

Copy link
Member Author

gingervik commented Mar 6, 2019

  1. Payment proof buttons overlap error message
    image

@gingervik gingervik moved this from Done to To do in Bright Boson 2.0 Mar 6, 2019

@anatolse anatolse moved this from To do to In progress in Bright Boson 2.0 Mar 7, 2019

anatolse added a commit that referenced this issue Mar 7, 2019

@anatolse anatolse moved this from In progress to Done in Bright Boson 2.0 Mar 7, 2019

@Sergei-Beam

This comment has been minimized.

Copy link
Member

Sergei-Beam commented Mar 12, 2019

point 8.2 reproduced again
image

@Sergei-Beam Sergei-Beam moved this from Done to To do in Bright Boson 2.0 Mar 12, 2019

@Sergei-Beam

This comment has been minimized.

Copy link
Member

Sergei-Beam commented Mar 14, 2019

  1. Transaction to myself
    For exchange transactions we should not show details and copy buttons
    image
  2. Transaction in status "sending"
    We decided to forbid open the proof while transaction not yet completed to exclude the possibility of fraud
    image

Note: So buttons should be available only for completed transactions

@anatolse anatolse moved this from To do to In progress in Bright Boson 2.0 Mar 19, 2019

echoby added a commit that referenced this issue Mar 21, 2019

echoby added a commit that referenced this issue Mar 21, 2019

anatolse added a commit that referenced this issue Mar 21, 2019

@anatolse anatolse moved this from In progress to Done in Bright Boson 2.0 Mar 21, 2019

@gingervik gingervik assigned Sergei-Beam and unassigned anatolse and echoby Mar 21, 2019

@Sergei-Beam

This comment has been minimized.

Copy link
Member

Sergei-Beam commented Mar 21, 2019

checked

Bright Boson 2.0 automation moved this from Done to Tested Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.