Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Swap] Display "Swap conditions match" first before claiming "Swap Accepted." #666

Closed
jurijakimuk opened this issue May 22, 2019 · 1 comment

Comments

4 participants
@jurijakimuk
Copy link
Member

commented May 22, 2019

Bug description
When swap conditions are equal - we don't need to rush with the statement "Swap accepted".
After the check of swap conditions it may turn out that there are insufficient balances in the wallets and such swaps must not be accepted.

To do (Suggestion)
When swap conditions equality test is passed we display smth like "Swap conditions match."
(Instead of "Swap accepted.")
And only then, when the wallet balances are checked and they are enough for the swap to succeed and maybe some other dependencies are checked - we can show the "Swap accepted." message to the user.

Screenshots (if applicable)
Current behavior:
image

@jurijakimuk jurijakimuk added the task label May 22, 2019

@jurijakimuk jurijakimuk added this to To do in Bright Boson 2.2 via automation May 22, 2019

@jurijakimuk jurijakimuk changed the title Display "Swap Conditions Check" result before claiming "Swap Accepted." Display "Swap conditions match" result before claiming "Swap Accepted." May 22, 2019

@jurijakimuk jurijakimuk changed the title Display "Swap conditions match" result before claiming "Swap Accepted." Display "Swap conditions match" result first before claiming "Swap Accepted." May 22, 2019

@jurijakimuk jurijakimuk changed the title Display "Swap conditions match" result first before claiming "Swap Accepted." Display "Swap conditions match" first before claiming "Swap Accepted." May 22, 2019

@jurijakimuk jurijakimuk changed the title Display "Swap conditions match" first before claiming "Swap Accepted." [Swaps] Display "Swap conditions match" first before claiming "Swap Accepted." May 22, 2019

@jurijakimuk jurijakimuk added the swap label May 22, 2019

@jurijakimuk jurijakimuk changed the title [Swaps] Display "Swap conditions match" first before claiming "Swap Accepted." [Swap] Display "Swap conditions match" first before claiming "Swap Accepted." May 22, 2019

@jurijakimuk jurijakimuk added the cli label May 22, 2019

@Aleksandr-Starun Aleksandr-Starun moved this from To do to In progress in Bright Boson 2.2 May 27, 2019

roman-strilets added a commit that referenced this issue Jun 21, 2019

@Aleksandr-Starun Aleksandr-Starun moved this from In progress to Done in Bright Boson 2.2 Jun 21, 2019

@gingervik gingervik assigned jurijakimuk and unassigned gingervik Jun 24, 2019

@jurijakimuk

This comment has been minimized.

Copy link
Member Author

commented Jun 24, 2019

OK in masternet, 5514

Bright Boson 2.2 automation moved this from Done to Tested Jun 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.