Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AwesomeTextView doesn't render icon's name with underscores #120

Closed
AlexanderKaraberov opened this issue Nov 4, 2015 · 2 comments
Closed
Labels
Milestone

Comments

@AlexanderKaraberov
Copy link

When I'm trying to set FA icon for AwesomeTextView like this awesomeTextView.setFontAwesomeIcon("fa-group"); it renders null. But this works: awesomeTextView.setFontAwesomeIcon("fa_group"); What is the purpose of these changes? In the previous versions it worked fine with underscores in the name. FA docs also use this notation
P.S. Or maybe I missed description of these changes somewhere in the README?

@jamie-beardedhen
Copy link
Contributor

Font Icons can now be specified as an XML enum attribute, and Android doesn't allow hyphens in value names:

https://github.com/Bearded-Hen/Android-Bootstrap/blob/master/AndroidBootstrap/src/main/res/values/attrs_font_awesome.xml

I'm marking this as a bug when the icon is a literal like "fa-group", as the library should be able to substitute the hyphen for an underscore.

redwerk pushed a commit to redwerk/Android-Bootstrap that referenced this issue Nov 6, 2015
redwerk pushed a commit to redwerk/Android-Bootstrap that referenced this issue Nov 6, 2015
@redwerk
Copy link

redwerk commented Nov 6, 2015

Hi,

There is a pull request for this - #122

Thanks!

jamie-beardedhen added a commit that referenced this issue Nov 10, 2015
Implementing support of hyphen within glyph name. #120
@jamie-beardedhen jamie-beardedhen added this to the 2.0.1 milestone Nov 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants
@redwerk @AlexanderKaraberov @jamie-beardedhen and others