Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradient Buttons #27

Closed
theDazzler opened this issue Dec 12, 2013 · 9 comments
Closed

Gradient Buttons #27

theDazzler opened this issue Dec 12, 2013 · 9 comments

Comments

@theDazzler
Copy link
Contributor

I'm making a new issue for each feature I added to discuss it because I added too many features at once in my fork. Here are the gradient buttons I added:

2013-12-12 03 28 44
2013-12-12 03 28 21

To use a gradient button, you just set the attribute "gradient" to true in xml. There are gradient square buttons as well, just not pictured

@cyrixmorten
Copy link

Looks really nice..

I tried adding it to my project, simply by overriding AndroidBootstrap. Unfortunately it made my buttons change size, making them thin.

@theDazzler
Copy link
Contributor Author

@cyrixmorten I ended up not adding this feature to the main project. I created my own fork and added the gradient buttons there along with some other extra features. The fork is here https://github.com/theDazzler/Android-Bootstrap. A few of the new features are listed at the top of the readme

@cyrixmorten
Copy link

@theDazzler I got the master branch of Android-Bootstrap working, then got a zip of your fork and copy-pasted the files to the imported Android-Bootstrap folder.

Is there any steps for installation of your project that differ from the main branch?

@theDazzler
Copy link
Contributor Author

No. It uses the same steps. Let me know if you have any trouble

@theDazzler
Copy link
Contributor Author

@cyrixmorten It uses the same steps, but you may have forgotten to copy over the gradient buttons drawables in the res folder. If I were you, I would just use my fork instead of copying and pasting files, because my code is different. It has all the same features plus more. My buttons extend from the button class as well, whereas the buttons in this fork do not, so you may run into issues depending on your code

@cyrixmorten
Copy link

@theDazzler Got it!

After inspecting the AndroidBootstrapTest project from your fork I found that I had to add this to my styles.xml

<style name="AppTheme" parent="AppBaseTheme">
    <!-- All customizations that are NOT specific to a particular API-level can go here. -->
    <item name="bootstrapButtonStyle">@style/BootstrapButton</item>
    <item name="bootstrapEditTextStyle">@style/BootstrapEditText</item>
    <item name="bootstrapHeadingStyle">@style/BootstrapTypographyHeading</item>
</style>

You may want to point that out in your readme.

Other than that, good work! A nice upgrade to the looks of my app 👍

Just noticed that I have a single small button bootstrapbutton:bb_size="small" and it seems to stay the default size.

@theDazzler
Copy link
Contributor Author

@cyrixmorten Glad you got it to work. Yea it's in the wiki here https://github.com/theDazzler/Android-Bootstrap/wiki, but not the readme. I'll have to add it

@jamie-beardedhen
Copy link
Contributor

Closing ticket as we are currently not planning a change for gradient colors - if there's enough demand then we can always reconsider.

@xpatient
Copy link

how to make "onClic and open new activity" on https://github.com/theDazzler/Android-Bootstrap.??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@theDazzler @cyrixmorten @jamie-beardedhen @xpatient and others