New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
secure xml #1
secure xml #1
Conversation
… xxe vulnerability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change - thank you. Could you drop the change to gitignore and reindent to 2 spaces?
I'm about to roll out a new release and I'd like this in there.
This reverts commit 00409c8.
| @@ -0,0 +1 @@ | |||
| mvn_version=3.5.4 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use the following to manage maven versions across developers http://mvnvm.org/
thought it might be useful here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - I'll take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good - thanks
I found out that this library is open to some xml vulnerabilities (xxe / ssrf)
This pull request ensures both the MethodBase and PostRequestPars types are relying on xml secure processing