Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash after quitting RT in Mac OSX 10.11.3 #3971

Closed
kapiliitr opened this issue Jul 15, 2017 · 8 comments

Comments

Projects
None yet
3 participants
@kapiliitr
Copy link

commented Jul 15, 2017

I am using RawTherapee versions 5.1 and 5.1.134 on Mac OSX El Capitan 10.11.3. Both versions crash after I close RT either by clicking the 'x' or by quitting from the main menu. Attached is a log I got from the crash report.

crash-close.txt

@Benitoite

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2017

Yes, I believe we all (macOS people) get that crash. Seems related to libomp. Reference: #3882 (comment)

@Beep6581 Beep6581 added the bug label Jul 15, 2017

@Benitoite

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2017

For the record I tried macports libomp-devel but get the same crash.

@Benitoite

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2017

Now I've tried building libiomp5 from https://www.openmprtl.org/sites/default/files/libomp_20160808_oss.tgz
with some success…

@kapiliitr can you test this new build which integrates this library for the crash on exit: [old link removed]

@kapiliitr

This comment has been minimized.

Copy link
Author

commented Jul 16, 2017

@Benitoite Raw therapee didn't even start for me. Attached is the error message and logs.
screen shot 2017-07-16 at 4 25 27 pm
openfail.txt

@Benitoite

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2017

Thanks for the report @kapiliitr !
I see macosx_bundle.sh is not copying the library into the app Frameworks dir. However it is setting the correct install_name in rawtherapee-bin and rawtherapee-cli. I wonder why the script is not completely installing the library.

@Benitoite

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2017

@kapiliitr Here's a new one to try. https://filebin.net/n79w2kos0xtbsug7/RawTherapee_OSX_10.9_64_5.1-162-g26077cd0.zip

I added a manual copy command to macosx_bundle.sh. Seems to open fine on my macOS 10.11 clean machine.

@kapiliitr

This comment has been minimized.

Copy link
Author

commented Jul 17, 2017

That works. I can confirm that my changes were saved and RT did not throw a crash error on closing from either the 'x' sign or from the menu. Thanks :)

@kapiliitr kapiliitr closed this Jul 17, 2017

@Benitoite

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2017

No prob @kapiliitr !

Benitoite added a commit to Benitoite/RawTherapee that referenced this issue Oct 23, 2017

License file for libiomp5.dylib
To prevent a crash during quit on mac, Intel's OSS libiomp5 is used in place of the older libomp provided by clang. This is the license file provided by Intel to cover the binary's redistribution. For even more info, see: Beep6581#3971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.