New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory leak when saving 32-bit TIFF #4375
Comments
Yes. It's the reading that triggers the bug.
Don't know, I used "uncompressed".
I didn't do anything to metadata myself. Maybe you need a slow or otherwise busy machine to trigger it. HTH, |
Reproduced, first post updated. |
Could not reproduce using @Floessie 's patch: diff --git a/rtexif/rtexif.cc b/rtexif/rtexif.cc
index 47d885e50..b6a60bbd8 100644
--- a/rtexif/rtexif.cc
+++ b/rtexif/rtexif.cc
@@ -3077,7 +3077,7 @@ void ExifManager::parse (bool isRaw, bool skipIgnored)
root->printAll ();
#endif
- } while (ifdOffset && !onlyFirst);
+ } while (ifdOffset > 0 && !onlyFirst);
// Security check : if there's at least one root, there must be at least one image.
// If the following occurs, then image detection above has failed or it's an unsupported file type. |
@Floessie if you're ok to commit, I could make a new coverity build right away. |
@Floessie only because you (or someone else?) asked me to make a new one two or three days ago. |
@Beep6581 In fact, it was me. That was because of the newly added code, but we don't have to trigger a scan for single line changes... |
@Floessie I'd be interested to understand your patch : what's the difference between the suppressed line and the new one ? I declared |
@Hombre57 The new one breaks the loop, if
Why can't
If a similar loop is copied from here, it should be fixed there, too. I hope, this explanation makes things clearer. It's just a common unsigned vs. signed bug. If an entity should only be positive (like absolute offsets or sizes), make them unsigned. Best, |
We don't. The last scan was 10 days and 68 commits ago, and I will make a new one for RC1. |
Ah, okay, I thought that was already done. |
Several times my whole computer froze (I managed to unfreeze it once by switching to TTY1 and killing RT) when testing patches and saving to various formats including 32-bit TIFF. I didn't encounter these freezes when saving only to 16-bit TIFF so the problem probably involves 32-bit TIFF files.
Steps to reliably reproduce:
amsterdam.pef
with Filmstrip visible, neutral profile./tmp
The text was updated successfully, but these errors were encountered: