MSYS2: last version of libjpeg-turbo triggers a link error

[gaaned92]

The last update of package mingw-w64-x86_64-libjpeg-turbo-2.0.0-1 triggers following error at link step:

C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/7.3.0/../../../../x86_64-w64-mingw32/bin/ld.exe: ../rtengine/librtengine.a(jdatasrc.cc.obj):jdatasrc.cc:(.rdata$.refptr.jpeg_std_message_table[.refptr.jpeg_std_message_table]+0x0): undefined reference to `jpeg_std_message_table'
collect2.exe: error: ld returned 1 exit status
make[2]: *** [rtgui/CMakeFiles/rth.dir/build.make:2278: rtgui/rawtherapee.exe] Error 1
make[1]: *** [CMakeFiles/Makefile2:282: rtgui/CMakeFiles/rth.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

There is no error during compilation.

the version 1.5.3 is ok

The two versions are uploaded here https://filebin.net/qglvvp0b2d2q8brl

[TooWaBoo]

How do I install the older version?
EDIT: Found it. :-)

[TooWaBoo]

@gaaned92
Looks like your linked file 1.5.3 is for 32bit and not 64bit?
Still get the error after downgrade.

[gaaned92]

@TooWaBoo Thanks, I forgot to include the 64 bits versions.
You can verify the libjpeg version installed: pacman -Qs libjpeg
I can build with gcc 8.2 and libjpeg-turbo 1.5.3

@heckflosse @Floessie @agriggio can you identify the reason of issue and which of libjpeg or Rawtherapee is responsible?

[TooWaBoo]

@gaaned92
Works now, it was my fault. I had to many backups. :-)

[Floessie]

Neither RT's nor libjpeg-turbo's code changed in respect of jpeg_std_message_table, so my wild guess is, that MinGW's linker was overly aggressive when building libjpeg-turbo, or that there's an incompatibility between the toolchain used for building libjpeg-turbo and the one you're using to build RT. The variable signature is fine. The error shouldn't strike RT alone, so keep on googling for "undefined reference to `jpeg_std_message_table'".

[Desmis]

Hello
I have been away some days, and I discover this problem

What must I do ?
Is the command :
$ pacman -U /var/cache/pacman/pkg/mingw-w64-x86_64-libjpeg-turbo-1.5.3-1-any.pkg.tar.xz
Solved the problem (as for lensfun)

Or must I do another thing
Thank you :)
jacques

[gaaned92]

Is the command :
$ pacman -U /var/cache/pacman/pkg/mingw-w64-x86_64-libjpeg-turbo-1.5.3-1-any.pkg.tar.xz
Solved the problem (as for lensfun)

Yes

Furthermore, if you want to avoid update of libjpeg-turbo until issue is solved,

in `/msys64/etc/pacman.conf` insert after
# Pacman won't upgrade packages listed in IgnorePkg and members of IgnoreGroup

IgnorePkg   =  mingw-w64-x86_64-libjpeg-turbo

[Desmis]

thank you :)

[TheSquirrelMafia]

Thanks for working on this issue!

[TooWaBoo]

I was able to compile successfully with the latest libjpeg-turbo by changing following in jdatasrc.cc.

Line 252

old

//const char * const jpeg_std_message_table[] = {
//#include "jerror.h"
//  NULL
//};
extern const char * const jpeg_std_message_table[];

new

const char * const jpeg_std_message_table[] = {
#include "jerror.h"
  NULL
};
//extern const char * const jpeg_std_message_table[];

I don't think that's the right way 'cause I don't know what I'm doing😄 but perhaps this helps to fix it.

[gaaned92]

@TooWaBoo good catch! At least we can compile with last libjpeg turbo 😆

But, a while ago, a dev modified on purpose jdatasrc.cc to override the corresponding jdatasrc.c of libjpegturbo package and this change is reverting one of the modifications.
So there is a risk that it breaks the jpeg error handler in some way.
@Floessie @heckflosse @agriggio is it safe to do that?

[heckflosse]

@gaaned92

But, a while ago, a dev modified on purpose jdatasrc.cc to override the corresponding jdatasrc.c of libjpegturbo package and this change is reverting one of the modifications.

I don't remember which dev that was. Can you shed some light into (I hope it wasn't me)?