Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make raw black and white level tools work on absolute values #5547

Open
Beep6581 opened this issue Nov 30, 2019 · 2 comments
Open

Make raw black and white level tools work on absolute values #5547

Beep6581 opened this issue Nov 30, 2019 · 2 comments
Assignees
Labels
Milestone

Comments

@Beep6581
Copy link
Owner

@Beep6581 Beep6581 commented Nov 30, 2019

I would find it more informational and clear if the current raw black and white levels were explicitly shown in spinboxes, allowing me to see the value and to directly change it. Currently (5.7) the raw black levels are offsets and the raw white level is a multiplier, and the user does not know what the detected levels are.

Concerning nomenclature, I propose to call them "black levels" and "white levels".

I can do the UI part.

I can't think of any real cases where not being able to use an offset or multiplier would be a problem (thinking of batch mode or of dynamic profiles). If you can, speak now.

@Beep6581 Beep6581 added this to the v5.9 milestone Nov 30, 2019
@Thanatomanic

This comment has been minimized.

Copy link
Collaborator

@Thanatomanic Thanatomanic commented Dec 1, 2019

I have no objections to exposing these values to the user. Good plan! The interface is already almost there.

As to the naming: I don't think it's appropriate to call both 'levels', in particular since one acts as an offset and the other as a multiplier. Could we change the behavior to be the same in both cases, or is there a practical argument to not do so? What would be your objection to use the current terms 'black point' and 'white point'?

@Beep6581

This comment has been minimized.

Copy link
Owner Author

@Beep6581 Beep6581 commented Dec 1, 2019

@Thanatomanic this issue is about getting rid of the offset and multiplier and working with the actual levels.

The current terms are misleading or vague - the sliders don't control the "raw black point" but an offset, and the "white-point correction" is a multiplier.

If the engine is capable of providing the actual levels used, then I don't see why we shouldn't see and be able to adjust them directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.