Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update automated development build filenames #5551

Closed
Beep6581 opened this issue Dec 2, 2019 · 8 comments
Closed

Update automated development build filenames #5551

Beep6581 opened this issue Dec 2, 2019 · 8 comments
Assignees
Milestone

Comments

@Beep6581
Copy link
Owner

Beep6581 commented Dec 2, 2019

The automated build filenames for RawTherapee and HDRMerge will use this template:

hdrmerge_release-v0.6_continuous-67-g1f0b1a0_20190927.AppImage
________ ____________ ______________________ ________.________
  name      branch         git describe        date     ext

Releases will use:

hdrmerge_v0.6.AppImage
________ ____.________
  name   tag    ext

Fields separated by underscores, where a field is the output of a command such as git describe.

https://github.com/jcelaya/hdrmerge/releases/tag/nightly
https://github.com/Beep6581/RawTherapee/releases/tag/nightly

https://github.com/aferrero2707/hdrmerge-ci/blob/master/package-appimage.sh#L115
https://github.com/aferrero2707/rt-appimage/blob/master/ci/package-appimage.sh#L227
https://github.com/aferrero2707/rt-win64/blob/master/ci/package-msys2.sh#L37
https://github.com/aferrero2707/rt-win64/blob/master/ci/package-w64.sh#L37

https://github.com/aferrero2707/rt-win64/blob/master/.travis.yml
https://github.com/aferrero2707/rt-appimage/blob/master/.travis.yml

@Beep6581 Beep6581 added this to the v5.8 milestone Dec 2, 2019
@Beep6581 Beep6581 self-assigned this Dec 2, 2019
@aferrero2707
Copy link
Collaborator

What about the target operating system? This might be needed if for example we generate zip files for both Win64 and macOS, and the branch and build dates are the same.

@Beep6581
Copy link
Owner Author

Beep6581 commented Dec 3, 2019

@aferrero2707 no problem adding OS names when the need arises.

Beep6581 added a commit to aferrero2707/rt-appimage that referenced this issue Jan 31, 2020
@Beep6581
Copy link
Owner Author

Fixed for AppImage, now for Windows.

@aferrero2707
Copy link
Collaborator

Thanks! Could you take care of the windows script as well, or should I do that?

@Beep6581
Copy link
Owner Author

Beep6581 commented Feb 1, 2020

@aferrero2707 as we're releasing this weekend and time's running short, if you could do the Windows script that would be great 👍

Development:

RawTherapee_branch_gitdescribe_date.exe
RawTherapee_branch_gitdescribe_date_win64.zip

Tagged release:

RawTherapee_gitdescribe.exe
RawTherapee_gitdescribe_win64.zip

So basically:

if [[ $RT_BRANCH = releases ]]; then
    ver="${GIT_DESCRIBE}"
else
    ver="${RT_BRANCH}_${GIT_DESCRIBE}_${curr_date}"
fi

and then append win64 for the zip file only.

@aferrero2707
Copy link
Collaborator

@Beep6581 I am taking care of the windows package naming right now...

@aferrero2707
Copy link
Collaborator

@Beep6581 @heckflosse windows names should be fine now. Could you check that the release packages also install in the appropriate folder?
https://github.com/Beep6581/RawTherapee/releases/download/nightly/RawTherapee_5.7.exe
https://github.com/Beep6581/RawTherapee/releases/download/nightly/RawTherapee_5.7_win64.zip

@Beep6581
Copy link
Owner Author

Beep6581 commented Feb 1, 2020

Thank you @aferrero2707

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants