Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Explicit PSR-11 support #1054
Hum, I think like #1014, there are several bc breaks. See the comments @stof made (It was on thing implementing / extending the interop interfaces, now implementing the psr's ones ; one should expect that these classes / exceptions accept the typehinting from the interop, but they don't).
Only the typehints should be changed to be compatible with psr 11.
Unless I'm reading and understanding it wrongly...
There's also no public API change, so the upgrade from Interop 1.1 to Interop 1.2 (which extends PSR-11) is non-breaking. This all means that for people depending on Interop container interfaces the change should be transparent. Unless they are locking particular minor version of Interop in their
The mentionned BC break is for example on your exceptions. Before the PSR-11 implementation, even though it is using
@stof's point was that the thing in behat that extends / implements something from interop AND/OR PSR11 should still accept / implement the interop interfaces, so that nothing breaks.
don't get me wrong though, I do not really care for BC Breaks, such a minor one is okay IMO.