Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented NarrativeFilter #570

Merged
merged 1 commit into from Mar 20, 2015
Merged

Conversation

wouterj
Copy link
Contributor

@wouterj wouterj commented Jun 23, 2014

Fixes #548

@stof
Copy link
Member

stof commented Jun 23, 2014

you need to bump the Gherkin requirement

@wouterj
Copy link
Contributor Author

wouterj commented Jun 23, 2014

@stof are you sure? Behat requires behat/gherkin: ~4.3 (https://github.com/Behat/Behat/blob/master/composer.json#L19 ) and the NarrativeFilter was added to 4.3.0: https://github.com/Behat/Gherkin/blob/v4.3.0/src/Behat/Gherkin/Filter/NarrativeFilter.php

@stof
Copy link
Member

stof commented Jun 23, 2014

ah sorry, I forgot we already bumped it for another Gherkin fix

@everzet
Copy link
Member

everzet commented Jun 23, 2014

This is a new feature. Thus, it should go into 3.1. I think we should fork the current master into 3.0 before merging new features

@stof
Copy link
Member

stof commented Jun 24, 2014

@everzet do we need it ? If we follow semver strictly, it would mean that people can update to the next minor version without breaking anything. This means that we would not need to provide patch releases for previous minor releases. See Twig for instance. It has never created maintenance branches for its minor releases in 3 years

@everzet
Copy link
Member

everzet commented Jun 24, 2014

@stof do we need what? This feature?

@wouterj
Copy link
Contributor Author

wouterj commented Jun 24, 2014

@everzet @stof meant a seperate 3.0 branch.

If you strictly follow semver (and I thought you planned to do that), none update in the complete 3.x serie should have a BC break. That means, from a BC perspective, that upgrading from 3.0 to 3.1 is equal to upgrading from 3.0.5 to 3.0.6. This means that you would just release a new minor version once a new feature is implemented (like this one) and then continue to increment the release versions for the 3.1 serie, until another feature is implemented which will be in 3.2, etc. In these cases, there is no need to maintain the 3.0.x and 3.1.x serie, only the latest 3.x version needs to be maintained.

@everzet everzet added this to the 3.1.0 milestone Jul 9, 2014
@wouterj
Copy link
Contributor Author

wouterj commented Sep 27, 2014

Is there any change this can be merged soonish? I'm now hired to integrate Behat in a Dutch company and they want me to write the specifications in Dutch.

everzet added a commit that referenced this pull request Mar 20, 2015
@everzet everzet merged commit a019865 into Behat:master Mar 20, 2015
@everzet
Copy link
Member

everzet commented Mar 20, 2015

@wouterj thank you very much for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for NarrativeFilter
3 participants