Support for inline comments in tables #39

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@xmeltrut
xmeltrut commented Nov 6, 2012

This adds supports for inline comments in tables. I've sometimes found the need to add extra information for other Gherkin authors for a particular table row, but currently it throws an error. For example:

  | column1 | column2 | column3 |
  | 1       | 1       | 1       |
  | 2       | 2       | 2       | # extra comment
  | 3       | 3       | 3       |
@everzet
Member
everzet commented Jan 28, 2013

Ok, here's the problem. I'm not against this feature itself, but I'm against any feature that makes Behat\Gherkin not compatible with cucumber/gherkin. And cucumber/gherkin doesn't support comments in tables.

Compatibility on feature level is really important for everyone as this way your feature descriptions will stay the same in any programming language and framework - you'll just be forced to change underlying test layer. Supporting any language feature that cucumber/gherkin doesn't will mean that you will not be able to use your features as business-regression layer with application rewrite and this is a bad thing.

Keeping this in mind, I'm closing this PR :(

@everzet everzet closed this Jan 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment