Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Few more possible regular expressions to check checkbox is checked #57

Merged
merged 2 commits into from Mar 9, 2013

Conversation

Projects
None yet
3 participants
Contributor

kssundar commented Dec 11, 2012

I added a couple of regular expressions that helps the user to check if a checkbox is checked or not on a page.

Committed here - de37a1a

Is it worth?

@stof stof and 1 other commented on an outdated diff Dec 11, 2012

src/Behat/MinkExtension/Context/MinkContext.php
@@ -381,6 +383,9 @@ public function assertCheckboxChecked($checkbox)
* Checks, that checkbox with specified in|name|label|value is unchecked.
*
* @Then /^the "(?P<checkbox>(?:[^"]|\\")*)" checkbox should not be checked$/
+ * @Then /^I (?:|should )see the checkbox "(?P<checkbox>(?:[^"]|\\")*)" (?:is not checked|is unchecked)$/
@stof

stof Dec 11, 2012

Owner

This does not look like an English sentence. you have 2 verbs

@kssundar

kssundar Dec 13, 2012

Contributor

Right. The we can remove "I should see .... " from the above regular expression and keep the rest.??

Owner

stof commented Dec 11, 2012

And the trait should be kept in sync with the class

Contributor

kssundar commented Dec 13, 2012

Could you please point it out at one example here? I am not able to figure out the trait. :)

(Sundar is new here and is trying to learn new stuff on git as much as possible. Please excuse.)

Owner

stof commented Dec 13, 2012

you have to update this file to keep the same step definitions

Contributor

kssundar commented Dec 13, 2012

I have updated as suggested and the commit is done here - b6df191

I above commit is on top of my previous commit de37a1a. Is this fine or should I do fork it again and commit with only the new changes?

@everzet everzet added a commit that referenced this pull request Mar 9, 2013

@everzet everzet Merge pull request #57 from kssundar/master
Few more possible regular expressions to check checkbox is checked
523f2e7

@everzet everzet merged commit 523f2e7 into Behat:master Mar 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment