Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use swagger dump as json schemas source #245

Merged
merged 3 commits into from Mar 22, 2018

Conversation

Projects
None yet
2 participants
@gpenverne
Copy link
Contributor

commented Mar 21, 2018

@Then the JSON should be valid according to swagger :dumpPath dump schema :schemaName
@Then the JSON should not be valid according to swagger :dumpPath dump schema :schemaName

@sanpii
Copy link
Member

left a comment

Thank you for work. Please also update the i18n/en.xliff.dist file with the now definitions.

*/
public function theJsonShouldNotBeValidAccordingToTheSwaggerSchema($dumpPath, $schemaName)
{
try {

This comment has been minimized.

Copy link
@sanpii

sanpii Mar 21, 2018

Member

The Asserter::not() method done exactly the same thing. Please use it.

@@ -1,3 +1,5 @@
@JSON

This comment has been minimized.

Copy link
@sanpii

This comment has been minimized.

Copy link
@gpenverne

gpenverne Mar 21, 2018

Author Contributor

Used locally to only run JSON behat test. Removed it.

gpenverne added some commits Mar 21, 2018

@sanpii

sanpii approved these changes Mar 22, 2018

@sanpii sanpii added this to the 3.2 milestone Mar 22, 2018

@sanpii sanpii added the enhancement label Mar 22, 2018

@sanpii sanpii merged commit 7e5b2d9 into Behatch:master Mar 22, 2018

2 checks passed

Scrutinizer Analysis: 2 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.