New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging #254

Closed
FireEmerald opened this Issue Apr 16, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@FireEmerald
Collaborator

FireEmerald commented Apr 16, 2018

The application shall provide logfiles in a format which is readable using Notepad++ e.g. This means no special characters and horrible linebreaks like now:

example

@Belphemur

This comment has been minimized.

Owner

Belphemur commented Apr 16, 2018

I chose to use TraceX to log. It's a binary format for the logs.

You'll find here the client to read the logs: https://github.com/MarkLTX/TracerX

@FireEmerald

This comment has been minimized.

Collaborator

FireEmerald commented Apr 26, 2018

I know that you can view the logfiles using TraceX, but the question is: Does a user also knows this, without taking a look at the Wiki? I don't think so. We shouldn't log entries in binary format because the logfile is never that huge that we have to take care of our disk space.

@Belphemur

This comment has been minimized.

Owner

Belphemur commented Apr 26, 2018

@Belphemur Belphemur added the Confirmed label May 9, 2018

Belphemur added a commit that referenced this issue May 9, 2018

Remove old logger
Replace by Serilog
Use JSON logging.
Fixes #254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment