New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite #226

Merged
merged 18 commits into from Nov 30, 2017

Conversation

Projects
None yet
2 participants
@Belphemur
Owner

Belphemur commented Nov 30, 2017

Fixes #225
Fixes #219
Fixes #217
Fixes #214
Fixes #200
Fixes #166

Belphemur added some commits Nov 21, 2017

Redo cycler, model and lister
Basing on NAudio and own new clean lib to only switch the devices.
First version without notification
Finish updating the code in the other class to use the NAudio objects.
Implement notification
Same way as before, directly connected into the MMEnumerator of Windows.
Bump version
For beta release
New numbering. No more X.Y.Z but X.Y
Add delete settings of app
Remove also the "portable mode" need to be redone correctly.

Fixes #216
@FireEmerald

This comment has been minimized.

Collaborator

FireEmerald commented on Installer/setup.iss in 0971c62 Nov 27, 2017

This string isn't included in the installer downloaded via the update process:
2017-11-27 18_32_36-setup - soundswitch

This comment has been minimized.

Owner

Belphemur replied Nov 27, 2017

Good point. I thought it would fallback to english... which it does ... for the other ones ...

When you have the time could you add the German translation of those strings ?

I'm also going to add the "Certificates:" as a localized string.

This comment has been minimized.

Collaborator

FireEmerald replied Nov 27, 2017

For sure, let me know when you added all strings to translate.

This comment has been minimized.

Owner

Belphemur replied Nov 27, 2017

Belphemur and others added some commits Nov 27, 2017

Add missing localized string in installer
Also put the english as first, to be the fallback language.
Fix accessing FriendlyName
When Device state == NotPresent the FriendlyName can be unaccessible.

Fixes #225
@Belphemur

This comment has been minimized.

Owner

Belphemur commented on 9bcabb3 Nov 29, 2017

Thanks for this 👍

@Belphemur Belphemur merged commit 00597aa into dev Nov 30, 2017

@Belphemur Belphemur deleted the rewrite branch Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment