/SoundSwitch

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Portuguese(Brazilian) to the installer. #275

Merged
merged 6 commits into from May 16, 2018

Conversation

Reviewers

@FireEmerald FireEmerald

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@aleczk @FireEmerald @Belphemur
@aleczk
Contributor

aleczk commented May 15, 2018 •
edited by FireEmerald

Olá,

Sorry for being such a newbie and screwing up the first pull request.

Now I think I got the basics of how to make it.

I added the lines and translation to the setup.iss and the products.iss to portuguese.

I also added some information to the readme.me that I think is missing.

Closes #273.

aleczk added some commits May 15, 2018

@aleczk
Adição do PT ao Setup
b4f33e5
@aleczk
Installation in Portuguese 
Olá,

Sorry for being such a newbie.

This is my first pull ever. I think I got the basics of how to make it.

I added the lines and translation to the **setup.iss** and the **products.iss** to portuguese.

I also added some information to the **readme.me** that I think it's missing.
b29048d
@FireEmerald

FireEmerald requested changes May 16, 2018
View changes

Installer/scripts/products.iss Outdated
@@ -12,48 +13,56 @@ de.depdownload_msg=Die folgenden Programme werden benötigt bevor das Setup fort
fr.depdownload_msg=Pour fonctionner cette application a besoin de :%n%n%1%nTélécharger et installer maintenant?
es.depdownload_msg=Las siguientes aplicaciones son requeridas para que el instalador pueda continurar:%n%n%1%n¿Descargar e instalarlo ahora?
it.depdownload_msg=Prima che l'installazione possa proseguire sono richieste le seguente applicazioni :%n%n%1%nVuoi scaricarle e installarle?
pt_br.depdownload_msg=As seguintes aplicações são necessárias antes que a instalação possa continuar:%n%n%1%nBaixar e instalar agora?

This comment has been minimized.

Sign in to view
Copy link
@FireEmerald

FireEmerald May 16, 2018

Collaborator

The fr and it strings have an additional space before the ":", please remove the leading space from the other strings so they are equal.
Installer/scripts/products.iss Outdated
en.depinstall_missing=%1 must be installed before setup can continue. Please install %1 and run Setup again.
de.depinstall_missing=%1 muss installiert werden bevor das Setup fortfahren kann. Bitte installieren Sie %1 und starten Sie das Setup erneut.
fr.depinstall_missing=%1 doit être installé pour que l'installation continue. Installez %1 et relancer l'installateur.
es.depinstall_missing=%1 debe ser instalado antes para poder continuar. Por favor, instala %1 y ejecuta Instalador otra vez.
it.depinstall_missing=Prima che l'installazione possa continuare deve essere installato %1.%nInstalla %1 e quindi riesegui l'installazione.
pt_br.depinstall_missing=%1 deve ser instalado para que o setup possa continuar. Por favor instale %1 e execute o instalador novamente.
en.depinstall_error=An error occured while installing the dependencies. Please restart the computer and run the setup again or install the following dependencies manually:%n
de.depinstall_error=Ein Fehler ist während der Installation der Abghängigkeiten aufgetreten. Bitte starten Sie den Computer neu und führen Sie das Setup erneut aus oder installieren Sie die folgenden Abhängigkeiten per Hand:%n
fr.depinstall_error=Nous n'avons pu installer les dépendences. Veuillez redémarrer votre ordinateur et relancer l'installation ou installer ces dépendences manuellement: %n

This comment has been minimized.

Sign in to view
Copy link
@FireEmerald

FireEmerald May 16, 2018

Collaborator

manuellement: %n -> manuellement:%n
Installer/setup.iss Outdated
en.ViewReadmeFile=View the README file
en.SupportTheProject=Support the project
en.ViewChangelogFile=View the CHANGELOG file
it.ViewReadmeFile=Visualizza file README
it.SupportTheProject=Supporta il progetto
it.ViewChangelogFile=Visualizza file CHANGELOG
pt_br.ViewReadmeFile=Visualizar o arquivo README
pt_br.SupportTheProject=Ajudar o projeto
pt_br.ViewChangelogFile=Visualizar o CHANGELOG

This comment has been minimized.

Sign in to view
Copy link
@FireEmerald

FireEmerald May 16, 2018

Collaborator

Please group these strings and add a blank line for better readability after each translated string like in products.iss:

en...
fr...
de...
es...
it...
pt...

en...
fr...
de...
es...
it...
pt...

aleczk added some commits May 16, 2018

@aleczk
Fixing typos and blank spaces
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
608dbcd
@aleczk
Fixing blank spaces
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
0c63aab
@aleczk
Added lines between [CustomMessages]
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
08621ea
@aleczk
Change the way the last 3 variables were grouped
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
f80ce26
@aleczk

This comment has been minimized.

Sign in to view
Contributor

aleczk commented May 16, 2018 •
edited

Okay, done. I had noticed the extra blank spaces in some lines from other languages but was afraid to change it since I'm not the one who coded it. I also grouped the last 3 strings in setup.iss for better readability and future changes, as you suggested.

I hope everything is okay.
@FireEmerald

FireEmerald approved these changes May 16, 2018
View changes

@Belphemur Belphemur merged commit 03def99 into Belphemur:dev May 16, 2018

@aleczk aleczk deleted the aleczk:PortugueseInstaller branch May 16, 2018

@aleczk aleczk restored the aleczk:PortugueseInstaller branch May 16, 2018

@aleczk aleczk deleted the aleczk:PortugueseInstaller branch May 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment